AO3-5799 Allow string value for quotes property in skins #4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates the CSS Cleaner to accept a `quotes`-style entry of 1-4 single-character values, separated by spaces
BoldestDungeon
force-pushed
the
AO3-5799__setStringValuesForQuotes
branch
from
bfa580a
to
3c4728c
Compare
brianjaustin
changed the title
Bilka2
reviewed
Oct 4, 2024
| @@ -32,6 +32,11 @@ module CssCleaner | |||
| DROP_SHADOW_VALUE_REGEX = Regexp.new("\\(\\s*(#{NUMBER_WITH_UNIT_REGEX}|#{COLOR_REGEX}\\s*)+\\s*\\)") | |||
| DROP_SHADOW_FUNCTION_REGEX = Regexp.new("#{DROP_SHADOW_NAME_REGEX}#{DROP_SHADOW_VALUE_REGEX}") | |||
|
|
|||
| # quotes can take up to 4 characters, wrapped in quotation marks and separated by spaces, including escaped tokens | |||
There was a problem hiding this comment.
From what I can tell, literally anything is allowed in the strings and there can be any number of pairs. With this code, the "They said" example I linked doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5799
Purpose
quotes-style entry of 1-4 single-character values, separated by spacesTesting Instructions
References
Are there other relevant issues/pull requests/mailing list discussions?
Credit
David Bilsky/Ironskink (He/Him)