Homework for lection #3 first commit #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check this code at CodeSandbox with the link |
src/promiseReducer.js
Outdated
| @@ -0,0 +1,26 @@ | |||
| const fn1 = () => { | |||
src/promiseReducer.js
Outdated
| return memo * value; | ||
| } | ||
|
|
||
| function promiseReduce(asyncFunctions, reduce, initialValue) { |
There was a problem hiding this comment.
попробуй пробежаться по asyncFunctions через reduce, и код станет в разы чище
src/promiseReducer.ts
Outdated
| @@ -0,0 +1,40 @@ | |||
| type PromiseFunc = () => Promise; | |||
There was a problem hiding this comment.
ну это не то, Promise принимает в себя дженерик. Сужай тип
src/promiseReducer.ts
Outdated
|
|
||
| export function promiseReduce(asyncFunctions : Array<PromiseFunc>, reduce : OurReduceFunc, initialValue : number) : Promise<number> { | ||
| return (asyncFunctions.length) ? asyncFunctions.reduce((prev, curr) => | ||
| prev.then(memo => { |
There was a problem hiding this comment.
давай сделаем проще и сделаем через await механизм
src/promiseReducer.ts
Outdated
| return (asyncFunctions.length) ? asyncFunctions.reduce(async (prev : Promise<number>, curr : PromiseFunc) => { | ||
| const memo = await prev; | ||
| const data = await curr(); | ||
| return Promise.resolve(reduce(memo, data)); |
There was a problem hiding this comment.
задачи возвращать промис не было. Зачем тебе делать await prev? ты возвращаешь промис, а потом его опять дожидаешься. Давай переделаем.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.