Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for invertWithDoc #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alecgibson
Copy link

This change adds support for the optional, but recommended
invertWithDoc(op, doc) -> op' method, which is already implemented as
Delta.invert()

This change adds support for the [optional, but recommended][1]
`invertWithDoc(op, doc) -> op'` method, which is already implemented as
[`Delta.invert()`][2]

[1]: https://github.com/ottypes/docs#optional-properties
[2]: https://github.com/quilljs/delta/#invert
@alecgibson alecgibson changed the title ✨ Add support for invertWithDoc for subtypes ✨ Add support for invertWithDoc Dec 22, 2021
@alecgibson
Copy link
Author

I've just seen this has already been proposed and rejected in #33@jhchen do you have any further insight on why this isn't valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant