Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issue #98/While In Dark Mode Text In The Search Bar In The Map Is Black  #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teamomiamigo
Copy link
Collaborator

This PR addresses the issue where the search bar text in dark mode was not readable. The following changes were implemented to ensure better usability and alignment with the dark mode theme from my previous commit, which was staged on not the proper branch, so a new PR has been made to show proper changes and test cases added:

  • Updated the TextInput styling in the ExploreScreen to dynamically set the text color based on the active theme (light or dark mode).
  • Adjusted the placeholderTextColor to match the dark mode text styling for improved readability.
  • Ensured the search box background color adheres to the dark mode theme for a cohesive user experience.

Then added Testing Cases:

  • Verified that the search bar text and placeholder are readable in both light and dark modes.
  • Ensured no regressions in existing functionality.
  • Manually tested the changes on both Android and iOS platforms.

@teamomiamigo teamomiamigo self-assigned this Dec 8, 2024
@teamomiamigo teamomiamigo linked an issue Dec 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

While In Dark Mode Text In The Search Bar In The Map Is Black
1 participant