-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 178- Fix Keyboard behavior in AddNoteScreen and add Test Cases #207
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teamomiamigo Your PR still hasn't passed all the checks. Make sure your PR passes all the checks. Please run the code locally and ensure all tests and functionalities are working properly.
why cant i see the editor in this ? |
# Conflicts: # lib/screens/mapPage/ExploreScreen.js
what was changed
TouchableWithoutFeedback
wrapping the full layout with TouchableWithoutFeedback that uses keyboard.dismiss when tapped outside the keyboard
returnKeyType
adding a done key to the keyboard in the TextInput to display the dismiss button to manually dismiss the keyboard when you are done with it,
maintaining editor focus
adding some useEffect logic to ensure that teh editor gains focus on the scope of what needs to be done appropriately after rendering
adding test cases
added test cases to ensure that it tests for tapping outside the keyboard, for pressing done, across multiple inputs, and that the UI is adjusting properly in relation to the KeyboardAvoidingView behavior.
why it was changed
The issue presented was to add a keyboard dismiss functionality , as the current version did not allow for you to dismiss properly and efficiently out of the keyboard while in the addnotescreen screen.
Screen.Recording.2024-12-01.at.5.23.38.PM.mov