Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 178- Fix Keyboard behavior in AddNoteScreen and add Test Cases #207

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

teamomiamigo
Copy link
Collaborator

what was changed

TouchableWithoutFeedback

wrapping the full layout with TouchableWithoutFeedback that uses keyboard.dismiss when tapped outside the keyboard

returnKeyType

adding a done key to the keyboard in the TextInput to display the dismiss button to manually dismiss the keyboard when you are done with it,

maintaining editor focus

adding some useEffect logic to ensure that teh editor gains focus on the scope of what needs to be done appropriately after rendering

adding test cases

added test cases to ensure that it tests for tapping outside the keyboard, for pressing done, across multiple inputs, and that the UI is adjusting properly in relation to the KeyboardAvoidingView behavior.

why it was changed

The issue presented was to add a keyboard dismiss functionality , as the current version did not allow for you to dismiss properly and efficiently out of the keyboard while in the addnotescreen screen.

Screen.Recording.2024-12-01.at.5.23.38.PM.mov

Screenshot 2024-12-01 at 5.40.05 PM.png

@teamomiamigo teamomiamigo self-assigned this Dec 1, 2024
@teamomiamigo teamomiamigo linked an issue Dec 1, 2024 that may be closed by this pull request
7 tasks
@teamomiamigo teamomiamigo changed the title Fix Keyboard behavior in AddNoteScreen and add Test Cases Issue 178- Fix Keyboard behavior in AddNoteScreen and add Test Cases Dec 1, 2024
Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teamomiamigo Your PR still hasn't passed all the checks. Make sure your PR passes all the checks. Please run the code locally and ensure all tests and functionalities are working properly.

@yashb196
Copy link
Collaborator

what was changed

TouchableWithoutFeedback

wrapping the full layout with TouchableWithoutFeedback that uses keyboard.dismiss when tapped outside the keyboard

returnKeyType

adding a done key to the keyboard in the TextInput to display the dismiss button to manually dismiss the keyboard when you are done with it,

maintaining editor focus

adding some useEffect logic to ensure that teh editor gains focus on the scope of what needs to be done appropriately after rendering

adding test cases

added test cases to ensure that it tests for tapping outside the keyboard, for pressing done, across multiple inputs, and that the UI is adjusting properly in relation to the KeyboardAvoidingView behavior.

why it was changed

The issue presented was to add a keyboard dismiss functionality , as the current version did not allow for you to dismiss properly and efficiently out of the keyboard while in the addnotescreen screen.

Screen.Recording.2024-12-01.at.5.23.38.PM.mov
Screenshot 2024-12-01 at 5.40.05 PM.png

why cant i see the editor in this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keyboard dismiss option on AddNoteScreen.tsx - Hacktoberfest
3 participants