MorePage Update #206
Merged
MorePage Update #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcAsironman
requested changes
Nov 26, 2024
There was a problem hiding this comment.
@AmarHadzic, good work! However, please follow the Figma design as mentioned in the GitHub issue description.
Changes required:
- Add an automatic carousel.
- The dark mode and light mode toggle should reflect the design exactly as it appears in Figma.
Expected output:
IMG_0355.MOV
rcAsironman
requested changes
Dec 2, 2024
There was a problem hiding this comment.
@AmarHadzicI found a few alignment issues in your work. On Android, the content in the MorePage overflows and occupies the status bar. Also, on iOS, when I scroll through the options, they overlap with the image carousel. I'll attach the screenshot and screen recording below.
ScreenRecording_12-02-2024.13-49-45_1.MP4
|
@rcAsironman , just resolved those issues |
yashb196
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203
What was changed
Updated the more page to reflect the Figma design. The more page was given a more modern look and cleaner layout. Now the more page is more structured and looks complete. This improves usability and user experience.
Why was it changed
Previously, the more page included too much text and looked plain, leading to a poor user experience. After the updates, the more page is visually appealing, consistent, and easy to navigate, leading to an improved user-experience.
How was it changed
The
MorePage.tsxwas completely rewritten based on the Figma design. ATeamPage.tsxfile was created to display the team in a nice consistent format. Also, theAppNavigation.tsxfile was edited to support go back and forth between the More page and its sub pages.