Maintained unused code in a separate file. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 18, 2024 14:34
… also fixed the issue with dark theme in morePage
… all test cases are passed
| @@ -18,3 +18,6 @@ grounded-* | |||
| # macOS | |||
| .DS_Store | |||
| yarn.lock | |||
|
|
|||
| # Ignore unused code file | |||
| UnUsedCode.tsx | |||
There was a problem hiding this comment.
You shouldn't keep UnUsedCode, if it's unused, just remove it (from your clone of the repo and from .gitignore).
I like the idea of cleaning up the unused code by deleting it. Thanks for keeping things clean.
There was a problem hiding this comment.
sure, Dr. Holdener, I will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was removed?
I removed the UnUsed and commented-out code and moved it to a separate file (UnUsedCode.tsx).
why was it removed?
It was removed to maintain clean code in the main branch.
How was it removed?
I removed the commented-out and unused code from each file, then created a separate file named UnUsedCode.tsx, where I kept all the information related to that piece of code, including file names, line numbers (start - end), and proper comments.