Fixed issue104 - added download specific functions and added download icon #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lyskawa-Aonyx - Great effort! But it looks like the download button is inconsistent with the rest of the page. I've attached images for your reference to achieve consistent styling for download buttons. Please feel free to use an icon library if needed. Preview modal: /temp: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue104
What was changed?
-added download button
-added functions to properly name downloaded files
Here, describe what part of the application you changed (e.g. login page, database, etc.). If possible, mention what specific components were added, removed, or modified.
-I specifically changed draftorcadashboard.js exclusively.
Why was it changed?
-this was changed to better flow with modern UI standards and to conform with better naming schemes for downloaded material.
Here, describe the issue that you are fixing with this code, and why your code fixes it.
-previously the program downloaded files with names such as "output". It now uses the user's input to name the downloaded file.