Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown and Custom selection for Section field #116

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hmunjampally
Copy link

Fixes #91

What was changed?

Changed default input field type in sections field to select options with first, last and custom as options. and data field in onSubmit and fetchDocumentPreview the sections is changed to so that objects is converted to array and match the backend data fields

Why was it changed?

#91 issue is to have a dropdown feature for sections field with first, last and custom as options. whereas first gives section 1 data, last gives last sections data and custom is similar to earlier input field where we can give 1,2,3... or range of values (1-5) .

How was it changed?

*files that I changed: in client-app->src->components->(DraftOrcaDashboard.js and OrcaDashboardComponents.js) files.
exact sections and lines of code where I changed:
in DraftOrcaDashboard.js:
onSubmit and fetchDocumentPreview part
const data = {}
lines changed: 100 - 107 and 175 - 182
and
Number of sections?
from single input filed to dropdown options first, last and custom (when custom selected new input field to enter sections will be created.
lines changed: 270 - 302)

same changes are made in OrcaDashboardComponent.js file
onSubmit and fetchDocumentPreview lines changed: 40 - 53; 80 - 93
Number of sections? lines changed: 150 - 183*

Screenshots that show the changes (if applicable):

@SiriChandanaGarimella
Copy link
Collaborator

@hmunjampally - Thank you for your contribution to the project! I will review the PR and let you know if any changes are required.

@SiriChandanaGarimella
Copy link
Collaborator

@hmunjampally - Great work! Tested it, and the frontend implementation looks good! However, this PR should wait until the backend changes are implemented, since merging this now would break the Preview and Download features.

@vakhil-98 - Please use these frontend changes and implement the backend functionality for the issue #91

@vakhil-98
Copy link
Collaborator

@SiriChandanaGarimella Understood. I will work on the backend implementation for issue #91 to support these frontend changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Section Selection with Dropdown for First, Last, and Custom Options
3 participants