Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tmp fields from function details page #164

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

BradleySheldon
Copy link
Collaborator

@BradleySheldon BradleySheldon commented Oct 14, 2024

Fixes #159

What was changed?
Fields that display "tmp" were removed.

Here, describe what part of the application you changed (e.g. login page, database, etc.). If possible, mention what specific components were added, removed, or modified.
This changed the function details page by removing the fields Standard Model, Field of Definition, Min Field of Definition, Field of Modull, Cycle Sizes, Critical Points Cardinality, and Post Critical Set.

Why was it changed?
They were changed because they held the value "tmp"

Here, describe the issue that you are fixing with this code, and why your code fixes it.
This removes unnecessary data and provides only relevant fields with meaningful data to be more neatly displayed for the user.

How was it changed?
This was changed by deleting the unnecessary fields with value of "tmp".

Here, get into detail about what files you modified, and talk about the most important lines in regards to fixing the issue.
CriticalPointPortraitTable.js (lines 40-43), InfoTable.js (lines 19-22, 29-33), and CriticalPountsTable.js (lines 15-18, 23-30) were all modified by simply deleting the lines of code of certain fields with "tmp" hard-coded to display.

Screenshots that show the changes (if applicable):

Copy link
Collaborator

@dracpak dracpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI is cleaned and it looks much more presentable! This should be good for main unless there's additional information that should be on there

@suprajamannava17 suprajamannava17 self-requested a review October 16, 2024 17:03
Copy link
Collaborator

@suprajamannava17 suprajamannava17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems great and meets the requirement.

@suprajamannava17 suprajamannava17 merged commit 3ce9e0f into main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Remove Specific Fields on the Function Details Page in Dynamical Systems
3 participants