HTML frontend #178
Merged
HTML frontend #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoshi-Okami
requested review from
ankyAgrawal,
BohanZhang1,
mohamdlog and
yashaswini-slu
as code owners
4 tasks
mohamdlog
approved these changes
Nov 28, 2024
Comment on lines
+1357
to
+1383
| <Box sx={{ display: 'flex', flexWrap: 'wrap', m: 1 }}> | ||
| <Paper elevation={3} sx={{ margin: '25px', padding: 2, width: '100%' }}> | ||
| <Typography variant="h5" component="h2" sx={{ fontFamily: 'sans-serif', fontWeight: 700 }}> | ||
| Interactable HTMLs | ||
| </Typography> | ||
| <ul> | ||
| {resp.htmlFiles && resp.htmlFiles.length > 0 ? ( | ||
| resp.htmlFiles.map((htmlFile, index) => ( | ||
| <li key={index}> | ||
| <Link | ||
| href={`http://localhost:5000${encodeURI(htmlFile.url)}`} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| sx={{ textDecoration: 'none', color: 'blue' }} | ||
| > | ||
| {htmlFile.name} | ||
| </Link> | ||
| </li> | ||
| )) | ||
| ) : ( | ||
| <Typography variant="body1" sx={{ fontStyle: 'italic' }}> | ||
| No HTML files available for interaction. | ||
| </Typography> | ||
| )} | ||
| </ul> | ||
| </Paper> | ||
| </Box> |
There was a problem hiding this comment.
This looks good. It's consistent with the other details on the frontend, and has its own "Interactable HTMLs" section.
Comment on lines
+148
to
+157
| # After processing all blobs, collect HTML files at any depth | ||
| html_blobs = bucket.list_blobs(prefix=prefix) | ||
| for html_blob in html_blobs: | ||
| if html_blob.name.endswith('.html'): | ||
| file_name = os.path.basename(html_blob.name) | ||
| # Create a proxy URL for the HTML file | ||
| proxy_url = f"/serve-html/{folder_name}/{file_name}" | ||
| relative_path = os.path.relpath(html_blob.name, prefix) | ||
| # Ensure URL is properly formatted | ||
| proxy_url = f"/serve-html/{folder_name}/{relative_path.replace(os.sep, '/')}" | ||
| result["htmlFiles"].append({ | ||
| "name": file_name, | ||
| "name": os.path.basename(html_blob.name), | ||
| "path": relative_path.replace(os.sep, '/'), # Relative path within the folder |
There was a problem hiding this comment.
This is needed for HTML's in nested files. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
what has changed: updated the frontend to display and link HTML files in a new browser tab.
why was it changed: It provides users with direct access to HTML reports to enhance the usability of the dashboard.
how was it changed: I adjusted the getFolderContents to include htmlFiles when fetching data and updated ReportDashboard.jsx to include clickable links for each HTML file in the AccordionDetails section.