173 implement report pulling in gcs storage class and refactor simulation server #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
mohamdlog
force-pushed
the
173-implement-report-pulling-in-gcs-storage-class-and-refactor-simulation-server
branch
from
e34f683 to
114744a
Compare
mohamdlog
approved these changes
Nov 28, 2024
Comment on lines
+8
to
+14
| from PythonClient.multirotor.storage.storage_config import get_storage_service | ||
|
|
||
| class AirSimApplication: | ||
| # Parent class for all airsim client side mission and monitors | ||
| def __init__(self): | ||
| # Set up the storage service | ||
| self.storage_service = GCSStorageService() | ||
| self.storage_service = get_storage_service() |
There was a problem hiding this comment.
This is great. Further abstracts away from direct implementation details.
| @@ -1,3 +1,3 @@ | |||
| from .gsc_storage_service import GCSStorageService | |||
| from .gcs_storage_service import GCSStorageService | |||
Comment on lines
+10
to
+25
| """Uploads a file to the cloud storage service.""" | ||
| pass | ||
|
|
||
| @abstractmethod | ||
| def list_reports(self): | ||
| """Lists all report batches from the storage service.""" | ||
| pass | ||
|
|
||
| @abstractmethod | ||
| def list_folder_contents(self, folder_name): | ||
| """Lists the contents of a specific report folder.""" | ||
| pass | ||
|
|
||
| @abstractmethod | ||
| def serve_html(self, folder_name, relative_path): | ||
| """Serves an HTML file from the storage service.""" |
There was a problem hiding this comment.
This is good. New methods to help us refactor simulation_server.
There was a problem hiding this comment.
This works, including uploading and viewing files on the react app, tested it myself.
There was a problem hiding this comment.
File is properly refactored, looks good.
There was a problem hiding this comment.
The best part. This module serves as the central place for all of the storage service settings. You can easily switch between different storage services by simply commenting or uncommenting the relevant lines. It helps keep everything organized and abstracted.
mohamdlog
requested review from
ankyAgrawal,
BohanZhang1 and
yashaswini-slu
as code owners
mohamdlog
deleted the
173-implement-report-pulling-in-gcs-storage-class-and-refactor-simulation-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#173
This should work for now, refactored and pulled out methods that I believed could be used somewhere else, back into the GCS class, added the methods used in simulator to be rooted in the GCS class while still abiding by react interactions.
It was changed to allow for a more easily changed and concentrated storage framework, no long do we have to chase down methods and build it from scratch 4 times.
I took all of the methods from the simulator and abstracted them into the GCS class, while keeping a method call in the simulator to abide by the @app method requirements. further methods that I believed would not be used else where I kept in simulator and changed its interactions to use our GCS class rather than hardcoding everything.