Issue 167 HTML file Support #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoshi-Okami
requested review from
ankyAgrawal,
BohanZhang1,
mohamdlog and
yashaswini-slu
as code owners
3 tasks
nguzinski
reviewed
Nov 11, 2024
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
I wanna say that .vscode should be in the .gitignore, currently, it just ignores .vs, if you're able, add .vscode to the .gitignore
There was a problem hiding this comment.
As Noah said, this should be added to .gitignore.
| if blob.name.endswith('.txt'): | ||
| # Download the text content | ||
| file_contents = blob.download_as_text() | ||
|
|
There was a problem hiding this comment.
maybe change this to case switch/ pattern matching to make more readable
| @@ -175,7 +212,6 @@ def process_gcs_directory(prefix, result, fuzzy_path_value): | |||
| "failContent": fail_content | |||
| } | |||
|
|
|||
| # Determine the monitor type and append the file data | |||
| if "UnorderedWaypointMonitor" in blob.name: | |||
There was a problem hiding this comment.
seems to be a repeat of above, maybe a way to make reduce code repetition
|
|
||
| elif blob.name.endswith('.txt'): | ||
| file_contents = blob.download_as_text() | ||
|
|
||
| info_content = get_info_contents(file_contents, "INFO", {}) | ||
| pass_content = get_info_contents(file_contents, "PASS", {}) | ||
| fail_content = get_info_contents(file_contents, "FAIL", {}) | ||
|
|
||
| file_data = { |
There was a problem hiding this comment.
repeat of above, some way to reduce code repition
mohamdlog
requested changes
Nov 12, 2024
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
As Noah said, this should be added to .gitignore.
mohamdlog
reviewed
Nov 19, 2024
mohamdlog
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
Modified the process_gcs_directory function to detect HTML files by generating a public URL for each HTML file. In addition, I ensured that the JSON includes a path attribute for HTML files containing the public URL.
The GCS bucket in the process_gcs_directory did not include HTML files because it didn't recognize them. Including HTML files that are categorized properly helps reduce integration issues later and allows for easier testing and validation.
Checked the JSON response for HTML file details with a valid path and now HTML reports can be found under the acceptance reports.