Add OpenMP SIMD pragmas to some loops #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenMP 4.5 introduced the
#pragma omp simd
annotation to tell the compiler a loop can be vectorized using SIMD instructions. It doesn't hurt to have it, since the pragmas are just ignored when disabled, and we can compile with only the OpenMP SIMD support and not get the whole OpenMP runtime, so there is no additional dependency.I don't know if this makes a large difference in QDLDL itself when doing a single solve, but I think this is something that will help OSQP with its multiple solves (since the SIMD annotations are all on the solve phase).