Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenMP SIMD pragmas to some loops #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add OpenMP SIMD pragmas to some loops #55

wants to merge 2 commits into from

Conversation

imciner2
Copy link
Member

@imciner2 imciner2 commented May 9, 2024

OpenMP 4.5 introduced the #pragma omp simd annotation to tell the compiler a loop can be vectorized using SIMD instructions. It doesn't hurt to have it, since the pragmas are just ignored when disabled, and we can compile with only the OpenMP SIMD support and not get the whole OpenMP runtime, so there is no additional dependency.

I don't know if this makes a large difference in QDLDL itself when doing a single solve, but I think this is something that will help OSQP with its multiple solves (since the SIMD annotations are all on the solve phase).

@imciner2 imciner2 requested a review from bstellato May 9, 2024 22:07
@coveralls
Copy link

coveralls commented May 9, 2024

Pull Request Test Coverage Report for Build 9024192663

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8940488794: 0.0%
Covered Lines: 88
Relevant Lines: 88

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants