Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tanzania: add the script for the Swahili language #2421

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Conversation

Famlam
Copy link
Collaborator

@Famlam Famlam commented Dec 25, 2024

  • Adds test cases for country codes and languages, so that mistakes are already detected by pytest/github workers
  • Remove the exception thrown during runtime. (Doesn't serve a purpose anymore, mistakes are detected by the tests)
  • Add sw as a Latin script (based on Wikipedia)

Fixes #2420

@frodrigo
Copy link
Member

Remove the exception thrown during runtime. (Doesn't serve a purpose anymore, mistakes are detected by the tests)

I would prefer we keep this.

Adds test cases for country codes and languages, so that mistakes are already detected by pytest/github workers. The runtime exception was kept on request.
@Famlam
Copy link
Collaborator Author

Famlam commented Dec 25, 2024

I would prefer we keep this.

Ok, I re-added it.

Edit: the added break was supposed to be in a follow-up PR, minor performance improvement. Accidentally already included it here. I hope it's fine

@frodrigo
Copy link
Member

Thank you.

@frodrigo frodrigo merged commit 55bd6e1 into dev Dec 26, 2024
6 checks passed
@Famlam Famlam deleted the famlam-lang-sw branch December 26, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No script setup for language 'sw'
2 participants