Autodetect the default network interface #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkvt
force-pushed
the
autodetect-default-interface
branch
from
7a8526d to
10ab3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
Hi,
this PR auto detects the default network interface as suggested in #13.
I thought that this could be done with the PYTHON2BASH configuration option but it is interpreted with the python function
ast.literal_evalin a script in the base image which only allows safe python data types, so this was not possible and the implementation here was required.I manipulated the check to make it fail and the container didn't start so everything seems to be working.
Thanks, Vincent