Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Add model 1511.03209 #3978

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Jul 26, 2024

@antonydellavecchia This model requires a couple of HUGE polynomials. It is a lot faster to save them as .mrdi (thanks to your hard work!) and load them, rather than to compute them anew. Drawback: The .mrdi files are large. The largest file that we need is about 130MB in size and I could not check it into this PR by github file size restriction to at most 100MB.

I will try to add the file here in a moment. It seems github does not allow me to upload a .mrdi file. So I will share it via slack with you.

Any suggestions on how to proceed?

(It goes without saying that this PR will fail without having that very file in experimental/FTheoryTools/src/LiteratureModels/Models/1511.03209.)

@HereAround
Copy link
Member Author

cc @apturner @emikelsons

@HereAround HereAround marked this pull request as draft July 26, 2024 16:41
@fingolfin
Copy link
Member

Adding a file of this size to the repository is not acceptable. We really need a separate means for data storage.

At the same time I wonder how efficient the encoding is. How many terms do you polynomials have? Are the homogeneous? What's the coefficient ring?

@HereAround
Copy link
Member Author

Adding a file of this size to the repository is not acceptable. We really need a separate means for data storage.

Fully agreed. I have alerted @antonydellavecchia on slack, and we already had a brief conversation on the matter. I am sure we can find a good solution. For instance, for another set of F-theory models, the required data is downloaded when needed. But here, the file(s) are big/massive...

At the same time I wonder how efficient the encoding is. How many terms do you polynomials have? Are the homogeneous? What's the coefficient ring?

A few numbers regarding the largest polynomial (a6) i.e. the one whose file I could not even temporarily attach to this PR, due to github's file size restrictions:

  • The polynomial a6 lives in a polynomial ring with 101 indeterminate over Q. This polynomial ring is graded by Z^98. (Let me avoid the exact gradings, unless truly necessary.)
  • The polynomial a6 is homogeneous with regard to this grading. (Let me not spell out that degree, unless truly needed.)
  • The polynomial a6 consists of roughly 230.000 monomials.
  • The coefficients of said polynomial a6 are taken to be random integers, if I recall correctly in the range from -250.000 to 250.000 (a6 is to model a generic section of a particular line bundle, for which the coefficients of the monomials should be sufficiently different from each other).

Maybe that helps to gauge the situation better?

@HereAround HereAround force-pushed the NewFTheoryModel branch 5 times, most recently from cb41c81 to 662e893 Compare July 28, 2024 08:18
@HereAround
Copy link
Member Author

HereAround commented Aug 9, 2024

After thinking this over a bit more, I have "minimized" this PR. It now just includes the build instructions, so that the creation of the model will take a long, long time. But as such, I believe this PR could be merged (provided the tests do not fail).

I have the .mrdi files (and so do @apturner and @emikelsons ), so that we can continue our work by loading from those files.

Whenever @antonydellavecchia is ready, we can enhance those .mrdi files by using the attribute saving framework as well as the serialization of the Lie algebras. With this, I believe we can then create a useful artifact.

Does that seem to make sense?

(Note that this PR includes the changes in #4002, as mutual changes in the metadata index files happened/to avoid a merge conflict.)

@HereAround HereAround marked this pull request as ready for review August 9, 2024 16:55
@HereAround HereAround force-pushed the NewFTheoryModel branch 2 times, most recently from 3e75bfd to 2ff3b37 Compare August 13, 2024 11:18
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (2008cc6) to head (d2d159c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3978   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         596      596           
  Lines       81994    81994           
=======================================
  Hits        69330    69330           
  Misses      12664    12664           
Files Coverage Δ
.../FTheoryTools/src/LiteratureModels/constructors.jl 95.63% <ø> (ø)

Copy link
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and most of the tests passed

@HereAround
Copy link
Member Author

@antonydellavecchia I will open a new PR shortly to discuss/implement the future serialization improvements for the FTheoryTools, including an artifact for the model added in this PR. For now, I am satisfied with being in principle able to create this model from scratch within OSCAR, even though this might take about 30 minutes on my laptop.

@HereAround HereAround merged commit 5c69c6c into oscar-system:master Aug 15, 2024
22 of 25 checks passed
@HereAround HereAround deleted the NewFTheoryModel branch August 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants