Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor util with generics and cleanup #176

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Refactor util with generics and cleanup #176

merged 2 commits into from
Nov 11, 2024

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Oct 5, 2024

With reference to issue #175

  • Introduce a generic implementation of unique()
  • remove unused functions
  • improve createInt64Range() performance by allocating all the needed data at start

grisu48
grisu48 reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this slipped under my radar.

LGTM, one minor nitpick but it's really more of a style question.

cmd/openqa-mon/util.go Outdated Show resolved Hide resolved
@ilmanzo @grisu48
Update cmd/openqa-mon/util.go
5c5bf04 
Co-authored-by: Felix Niederwanger <[email protected]>
@grisu48 grisu48 merged commit cd8e14f into os-autoinst:main Nov 11, 2024
5 checks passed
@grisu48
Copy link
Collaborator

grisu48 commented Nov 11, 2024

Thank you @ilmanzo 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grisu48 grisu48 grisu48 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilmanzo @grisu48