added devel/lib/?.so to the LUA_CPATH so readline.so can be found in … #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a pure catkin workspace (no call to 'make', only 'catkin_make')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a pure catkin workspace (no call to 'make', only 'catkin_make')
When I added this package to a catkin workspace and ran catkin_make, readline.so was generated in devel/lib not in the src dir (which is expected). The env-hook file for develspace only adds the src path to LUA_CPATH. The src path is only valid if you manually call 'make', but that's not how one should operate in a catkin environment, and instead should call catkin_make. This addition puts the catkin devel space ahead of the src tree, supporting both options and giving precedence to the catkin_make artifact.