Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.6 code sample updates + version updates #174

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

RizaFarheen
Copy link
Contributor

@RizaFarheen RizaFarheen commented Nov 5, 2024

  • Updated main Readme file with latest 2.1.6 code samples
  • Removed rest of the sections and added links here
  • Deprecation notice

Copy link
Contributor

@jmigueprieto jmigueprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @RizaFarheen

  • Can you please add a description to your PR?
  • What are we doing with all the sections removed from the Readme.md? relocate them?, rewrite them?

@RizaFarheen
Copy link
Contributor Author

RizaFarheen commented Nov 5, 2024

LGTM - @RizaFarheen

  • Can you please add a description to your PR? - done
  • What are we doing with all the sections removed from the Readme.md? relocate them?, rewrite them? - The removed sections already reside within docs folder as separate readmes. I have just linked them to make the main readme simple and straight forward to build the sample app!

As a next action - we can verify the pending examples and update the main readme with the working code - WDYT

@jmigueprieto
Copy link
Contributor

Integration test

LGTM - @RizaFarheen

  • Can you please add a description to your PR? - done
  • What are we doing with all the sections removed from the Readme.md? relocate them?, rewrite them? - The removed sections already reside within docs folder as separate readmes. I have just linked them to make the main readme simple and straight forward to build the sample app!

As a next action - we can verify the pending examples and update the main readme with the working code - WDYT

sounds good.

@jmigueprieto jmigueprieto merged commit 798b434 into orkes-io:main Nov 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants