CL-858 Adding Athena support for data catalogs and prepared statements #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danarbaugh
reviewed
Mar 27, 2024
There was a problem hiding this comment.
I see the following log output when using https://github.com/oreillymedia/cl-cloud-user-creator/pull/263 with this branch to create resources from https://github.com/oreillymedia/cl-tf-aws/pull/41:
us-east-1 - AthenaPreparedStatement - my_prepared_statement - [StatementName: "my_prepared_statement", WorkGroup: "primary"] - triggered remove
us-east-1 - AthenaDataCatalog - athena-data-catalog - [Name: "athena-data-catalog"] - triggered remove
...
us-east-1 - AthenaPreparedStatement - my_prepared_statement - [StatementName: "my_prepared_statement", WorkGroup: "primary"] - removed
us-east-1 - AthenaDataCatalog - athena-data-catalog - [Name: "athena-data-catalog"] - removed
The Nuke Inventory spreadsheet column for "aws-nuke namespace" still has the Cloud Control resource types for these resources. We should update them to reflect your AWS Nuke resource name. |
danarbaugh
approved these changes
Mar 27, 2024
corybekk
pushed a commit
that referenced
this pull request
Nov 6, 2024
* chore: cleanup and standardize mock generation * chore: improving docs and makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for AWS athena data catalogs and prepared statements.
The test script for creating these resources can be found here
Note
These resource types show supported by cloud control, but when using the cloud control resource types to attempt to clean these resources, they failed to find user created resources in my testing.