-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeGuru Reviewer RepositoryAssociation support #18
Conversation
Signed-off-by: Gabriela S. Soria <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good at first glance. I haven't had a chance to build and run it yet and I'm going to take a sick day the rest of today. I did leave one small thought online. I'll try to test this as soon as I'm back online!
} | ||
|
||
func init() { | ||
register("CodeGuruReviewerRepositoryAssociation", ListCodeGuruReviewerRepositoryAssociations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we specify the CC API association here to override? I think the following is the syntax, but I wouldn't blindly accept this suggestion if I were you. 😸
register("CodeGuruReviewerRepositoryAssociation", ListCodeGuruReviewerRepositoryAssociations) | |
register("CodeGuruReviewerRepositoryAssociation", ListCodeGuruReviewerRepositoryAssociations, | |
mapCloudControl("AWS::CodeGuruReviewer::RepositoryAssociation")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this! The cloud control resource doesn't work, do you think we should include the association anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. If I remember correctly, the association essentially tells AWS Nuke to use the module instead of the CC API if both happen to be specified in someone's configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Addressed in 888f8d2
Signed-off-by: Gabriela S. Soria <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bingo!
us-east-1 - CodeGuruReviewerRepositoryAssociation - [AssociationArn: "arn:aws:codeguru-reviewer:us-east-1:476209218594:association:37126b8b-a354-485e-9896-ad98cdd074fe", AssociationId: "37126b8b-a354-485e-9896-ad98cdd074fe", Name: "MyDemoRepo", Owner: "476209218594", ProviderType: "CodeCommit"] - removed
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Attempting to delete CodeGuru
RepositoryAssociations
using the Cloud Control API (AWS::CodeGuruReviewer::RepositoryAssociation
) results in these errors:This PR adds a new module to support CodeGuru
RepositoryAssociations
.Testing
Create Codecommit and CodeGuru resources:
Then run aws-nuke specifying
CodeGuruReviewerRepositoryAssociation
resource.And finally, verify if the resource was cleanup correctly, by running