-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for additional codebuild resources #17
Conversation
Signed-off-by: Gabriela S. Soria <[email protected]>
Signed-off-by: Gabriela S. Soria <[email protected]>
Signed-off-by: Gabriela S. Soria <[email protected]>
Signed-off-by: Gabriela S. Soria <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These modules worked for me! I ran the test script in conjunction with the companions PRs and saw resources created and removed. I left a small comment in line about something that stuck out to me, but nothing big.
if resp == nil { | ||
return nil, nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this follow a different pattern than the modules above? This is the only one where I see if resp == nil
. Reading the SDK docs doesn't clarify to me when the response would ever be nil
.
I also notice a lack of pagination, but that appears correct as this endpoint does not seem to be paginated if I'm reading the docs correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a previous version of this module I had an error saying resp could be null. I double checked, and it looks to me that it is actually not needed. Removed it in 6c8489e Thanks for catching this @sstoops
Regarding the pagination, you are right, this endpoint is not paginated, SourceCredentialsInfo doesn't have a NextToken
field.
Signed-off-by: Gabriela S. Soria <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR includes new modules to handle Codebuild builds, build batches, report groups, and source credentials. Adding support for webhooks and reports was not needed as these resources depend on the project and project's builds respectively.
Testing
After creating the codebuild resources using the script mentioned below, run aws-nuke specifying the following resources:
Once aws-nuke finishes, verify that there are no resources left with the following commands:
Setup