QoS volume list #349
Merged
QoS volume list #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek-koltun
commented
Apr 28, 2023
glimchb
reviewed
May 1, 2023
pkg/middleend/qos.go
Outdated
| for _, qosVolume := range s.volumes.qosVolumes { | ||
| volumes = append(volumes, proto.Clone(qosVolume).(*pb.QosVolume)) | ||
| } | ||
| sort.Sort(qosVolumesSortedByID(volumes)) |
There was a problem hiding this comment.
I'd keep sort since map ordering is unpredictable in Go even if we run a range loop over the same map multiple times.
glimchb
requested changes
May 1, 2023
artek-koltun
force-pushed
the
feat-list-qos-volumes
branch
from
f69eb9d to
aee6d06
Compare
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 81.85% 81.84% -0.02%
==========================================
Files 16 16
Lines 1990 2010 +20
==========================================
+ Hits 1629 1645 +16
- Misses 320 323 +3
- Partials 41 42 +1
|
artek-koltun
force-pushed
the
feat-list-qos-volumes
branch
2 times, most recently
from
9ec2b12 to
141b8d5
Compare
Signed-off-by: Artsiom Koltun <[email protected]>
artek-koltun
force-pushed
the
feat-list-qos-volumes
branch
from
141b8d5 to
19ca1d8
Compare
Signed-off-by: Artsiom Koltun <[email protected]>
glimchb
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.