feat(bgp): cleanup the linting errors #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the BGP message name to BgpRouter. Signed-off-by: Keith Wiles <[email protected]>
Clean up lint errors when option is removed. Signed-off-by: Keith Wiles <[email protected]>
Clean up lint errors when option is removed. Signed-off-by: Keith Wiles <[email protected]>
Clean up lint errors when option is removed. Signed-off-by: Keith Wiles <[email protected]>
Clean up lint errors when option is removed. Signed-off-by: Keith Wiles <[email protected]>
Clean up lint errors when option is removed. Signed-off-by: Keith Wiles <[email protected]>
Clean up lint errors when option is removed. Signed-off-by: Keith Wiles <[email protected]>
…:required-fields Clean up lint errors when option is removed. Signed-off-by: Keith Wiles <[email protected]>
|
@KeithWiles The Commitlint is failing on the earlier checkin's with the subject missing. You should be able to update the commit messages and do a push --force to resolve. In the meantime, I will review the changes. |
KeithWiles
force-pushed
the
bgp-fix-lint-errors
branch
2 times, most recently
from
37f280f to
f58b131
Compare
sandersms
reviewed
Aug 7, 2024
network/cloud/cloudrpc.proto
Outdated
| // bgp | ||
| Bgp bgp = 2 [(google.api.field_behavior) = REQUIRED]; | ||
| BgpRouter bgp_router = 2 [(google.api.field_behavior) = REQUIRED]; |
There was a problem hiding this comment.
Don't we need a position 1 in the message? This is showing as 2
There was a problem hiding this comment.
Yes, I will fix these
sandersms
reviewed
Aug 7, 2024
network/cloud/cloudrpc.proto
Outdated
| // Update BgpRouter request | ||
| message UpdateBgpRouterRequest { | ||
| // updated bgp router info | ||
| BgpRouter bgp_router = 2 [(google.api.field_behavior) = REQUIRED]; |
There was a problem hiding this comment.
Should this be position 1 instead of position 2?
Fix up the lint errors after changing the Makefile to remove the options to disable the linting errors. The Makefile change is not committed in this PR request to allow the rest of the protobuf files to build until all protobuf files are updated. Fixed and updated the two files bgp.proto and cloudrpc.proto files to address the follow lint error types. Also the generated files are included in this PR. --disable-rule=core::0123 --disable-rule=core::0131 --disable-rule=core::0132 --disable-rule=core::0133 --disable-rule=core::0134 --disable-rule=core::0140 --disable-rule=core::0156 --disable-rule=core::0158 --disable-rule=core::0191 --disable-rule=core::0192 --disable-rule=core::0203 --disable-rule=core::0216 --disable-rule=client-libraries::4232::required-fields Signed-off-by: Keith Wiles <[email protected]>
KeithWiles
force-pushed
the
bgp-fix-lint-errors
branch
from
f58b131 to
6237793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up the lint errors after changing the Makefile to remove
the options to disable the linting errors. The Makefile change
is not committed in this PR request to allow the rest of the
protobuf files to build until all protobuf files are updated.
Fixed and updated the two files bgp.proto and cloudrpc.proto files
to address the follow lint error types. Also the generated files
are included in this PR.
--disable-rule=core::0123
--disable-rule=core::0131
--disable-rule=core::0132
--disable-rule=core::0133
--disable-rule=core::0134
--disable-rule=core::0140
--disable-rule=core::0156
--disable-rule=core::0158
--disable-rule=core::0191
--disable-rule=core::0192
--disable-rule=core::0203
--disable-rule=core::0216
--disable-rule=client-libraries::4232::required-fields
Signed-off-by: Keith Wiles [email protected]