Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resource name IDENTIFIER enforcement #348

Closed
wants to merge 2 commits into from

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Aug 31, 2023

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb linked an issue Aug 31, 2023 that may be closed by this pull request
@glimchb
Copy link
Member Author

glimchb commented Aug 31, 2023

new linter PR to enforce IDENTIFIER is merged googleapis/api-linter#1241
waiting on the new release https://github.com/googleapis/api-linter/releases
comes from googleapis/api-linter#1243

@glimchb glimchb added the bug Something isn't working label Aug 31, 2023
@mardim91
Copy link
Contributor

mardim91 commented Sep 8, 2023

The changes to the EVPN GW API looks good to me. You have the green light from my side to merge this when this is needed.

@glimchb
Copy link
Member Author

glimchb commented Sep 12, 2023

@glimchb
Copy link
Member Author

glimchb commented Sep 12, 2023

now waiting on https://github.com/docker-multiarch/google-api-linter/tags

released!

now fails on

docker run --user=$(id -u):$(id -g) --rm -v "/home/glimcb/opiproject/opi-api/storage":/defs -v "/home/glimcb/opiproject/opi-api/storage/../common/v1":/common namely/protoc-all:1.51_2 -i /common --lint -d v1alpha1 -l go -o ./v1alpha1/gen/go/  --go-source-relative
frontend_virtio_scsi.proto:170:39: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior".
frontend_virtio_scsi.proto:190:39: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior".
frontend_virtio_scsi.proto:216:39: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior".

but we do have googleapis/googleapis@f5987af

so probably need new release of https://hub.docker.com/r/namely/protoc-all/tags

waiting on namely/docker-protoc#382

@glimchb
Copy link
Member Author

glimchb commented Oct 12, 2023

merged #387 instead

@glimchb glimchb closed this Oct 12, 2023
@glimchb glimchb deleted the identifier branch October 12, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is OUTPUT_ONLY a correct annotation for name field ?
2 participants