Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage API changes with name and field_behavior #317

Merged
merged 13 commits into from
Aug 2, 2023
Merged

Storage API changes with name and field_behavior #317

merged 13 commits into from
Aug 2, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Aug 1, 2023 •
edited
Loading

  • feat(storage): fill field_behavior for resource name
  • feat(storage): fix field numbers
  • feat(storage): use name key in statistics
  • feat(storage): leftover fixes to fields and numbers
  • feat(storage): change from OPTIONAL to OUTPUT_ONLY
  • feat(storage): fix AIP core::0127:resource-name-extraction
  • feat(storage): fix AIP core::0127::http-annotation
  • feat(storage): auto-generate protos
  • refactor(storage): add IMMUTABLE behavior for resource name field

see https://google.aip.dev/203

@glimchb glimchb requested a review from jainvipin August 1, 2023 18:04
@intelfisz
Copy link

@glimchb - please change the commit msgs for fixes to have fix(storage) as prefix

@artek-koltun
Copy link
Contributor

artek-koltun commented Aug 2, 2023 •
edited
Loading

@glimchb - please change the commit msgs for fixes to have fix(storage) as prefix

There are some guidance from angular here. Based on that:
feat(storage): fill field_behavior for resource name -> refactor/feat
feat(storage): fix field numbers -> fix
feat(storage): use name key in statistics -> refactor/feat
feat(storage): leftover fixes to fields and numbers -> refactor/feat
feat(storage): change from OPTIONAL to OUTPUT_ONLY -> refactor/feat
feat(storage): fix AIP core::0127:resource-name-extraction -> ci
feat(storage): fix AIP core::0127::http-annotation -> ci
feat(storage): auto-generate protos -> chore? it is a special category in Conventional commit but missed in Angular for such housekeeping tasks

@glimchb glimchb mentioned this pull request Aug 2, 2023
Closed
@glimchb glimchb marked this pull request as ready for review August 2, 2023 14:14
@glimchb glimchb requested a review from a team as a code owner August 2, 2023 14:14
@glimchb
Copy link
Member Author

glimchb commented Aug 2, 2023

@glimchb - please change the commit msgs for fixes to have fix(storage) as prefix

done, thanks for suggestion

glimchb added 10 commits August 2, 2023 17:18
@glimchb
refactor(storage): fill field_behavior for resource name
f74625e 
Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
fix(storage): fix field numbers
7d54826 
Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
refactor(storage): use name key in statistics
08e32fc 
Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
refactor(storage): leftover fixes to fields and numbers
a5be930 
Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
feat(storage): change from OPTIONAL to OUTPUT_ONLY
f822e91 
See https://google.aip.dev/203#output-only

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
chore(storage): auto-generate protos
5c93a61 
Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
fix(storage): remove unused object_key.proto
9878d9a 
Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
ci(storage): fix AIP core::0127:resource-name-extraction
4f9ddad 
+-----------------------------+------------------+----------------+
|            RULE             | TOTAL VIOLATIONS | VIOLATED FILES |
+-----------------------------+------------------+----------------+
| core::0127::http-annotation |               14 |              8 |
| core::0192::has-comments    |              408 |              9 |
+-----------------------------+------------------+----------------+

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
chore(storage): auto-generate protos
27573ca 
Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
ci(storage): fix AIP core::0127::http-annotation
5cadf06 
Signed-off-by: Boris Glimcher <[email protected]>
artek-koltun
artek-koltun approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at the moment

@glimchb glimchb merged commit 76c2f23 into opiproject:main Aug 2, 2023
This was referenced Aug 14, 2023
Closed
Closed
This was referenced Sep 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artek-koltun artek-koltun artek-koltun approved these changes

@jainvipin jainvipin Awaiting requested review from jainvipin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glimchb @intelfisz @artek-koltun