Skip to content

Commit

Permalink
fix: update meta args
Browse files Browse the repository at this point in the history
Related to #53

Signed-off-by: Boris Glimcher <[email protected]>
  • Loading branch information
glimchb committed Mar 26, 2024
1 parent fddd8e8 commit 0780890
Show file tree
Hide file tree
Showing 15 changed files with 214 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .ansible-lint-ignore
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
roles/get_bmc_facts/tasks/main.yml var-naming[no-jinja]
roles/bmc_factory_reset/defaults/main.yml var-naming[no-role-prefix]
roles/bmc_fw_update/defaults/main.yml var-naming[no-role-prefix]
roles/bmc_reboot/defaults/main.yml var-naming[no-role-prefix]
roles/bmc_session/defaults/main.yml var-naming[no-role-prefix]
roles/enable_secure_boot/defaults/main.yml var-naming[no-role-prefix]
roles/get_bmc_facts/defaults/main.yml var-naming[no-role-prefix]
roles/update_bmc_password/defaults/main.yml var-naming[no-role-prefix]
5 changes: 5 additions & 0 deletions roles/bmc_factory_reset/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.

---
# defaults file for bmc_factory_reset

https_port: 443

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_factory_reset/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_factory_reset_ as a prefix. (vars: https_port)
28 changes: 28 additions & 0 deletions roles/bmc_factory_reset/meta/argument_specs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.
---
argument_specs:
main:
version_added: "1.0.0"
short_description: Factory reset of DPU BMC
description:
- Reset all states of the DPU BMC to factory defaults.
options:
hostname:
required: true
type: str
description:
- DPU BMC IP Address.
username:
type: str
description:
- DPU BMC username.
password:
type: str
description:
- DPU BMC user password.
https_port:
type: int
description:
- DPU BMC port.
default: 443
1 change: 1 addition & 0 deletions roles/bmc_fw_update/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ bmc_fw_update_job_wait: true
bmc_fw_update_inventory_name: bmc_firmware
bmc_fw_update_image_file: /tmp/bf3-bmc-24.01-5_opn.fwpkg
bmc_fw_update_image_url: https://content.mellanox.com/BlueField/BMC/24.01-5-Jan-2024/{{ bmc_fw_update_image_file | basename }}
https_port: 443

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)

Check warning on line 12 in roles/bmc_fw_update/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_fw_update_ as a prefix. (vars: https_port)
18 changes: 18 additions & 0 deletions roles/bmc_fw_update/meta/argument_specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,24 @@ argument_specs:
description:
- Update the Firmware of the DPU BMC from URL or local file.
options:
hostname:
required: true
type: str
description:
- DPU BMC IP Address.
username:
type: str
description:
- DPU BMC username.
password:
type: str
description:
- DPU BMC user password.
https_port:
type: int
description:
- DPU BMC port.
default: 443
bmc_fw_update_reboot:
description:
- Provides the option to apply the update packages immediately or in the next reboot.
Expand Down
5 changes: 5 additions & 0 deletions roles/bmc_reboot/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.

---
# defaults file for bmc_reboot

https_port: 443

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_reboot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_reboot_ as a prefix. (vars: https_port)
28 changes: 28 additions & 0 deletions roles/bmc_reboot/meta/argument_specs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.
---
argument_specs:
main:
version_added: "1.0.0"
short_description: Role to reset and restart DPU BMC
description:
- Role to reset and restart DPU BMC.
options:
hostname:
required: true
type: str
description:
- DPU BMC IP Address.
username:
type: str
description:
- DPU BMC username.
password:
type: str
description:
- DPU BMC user password.
https_port:
type: int
description:
- DPU BMC port.
default: 443
5 changes: 5 additions & 0 deletions roles/bmc_session/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.

---
# defaults file for bmc_session

https_port: 443

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/bmc_session/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use bmc_session_ as a prefix. (vars: https_port)
28 changes: 28 additions & 0 deletions roles/bmc_session/meta/argument_specs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.
---
argument_specs:
main:
version_added: "1.0.0"
short_description: Role to manage DPU BMC session
description:
- Role to manage (create and delete) the DPU BMC authentication session.
options:
hostname:
required: true
type: str
description:
- DPU BMC IP Address.
username:
type: str
description:
- DPU BMC username.
password:
type: str
description:
- DPU BMC user password.
https_port:
type: int
description:
- DPU BMC port.
default: 443
5 changes: 5 additions & 0 deletions roles/enable_secure_boot/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.

---
# defaults file for enable_secure_boot

https_port: 443

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/enable_secure_boot/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use enable_secure_boot_ as a prefix. (vars: https_port)
28 changes: 28 additions & 0 deletions roles/enable_secure_boot/meta/argument_specs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.
---
argument_specs:
main:
version_added: "1.0.0"
short_description: Enable DPU secure boot
description:
- This role enables DPU secure boot.
options:
hostname:
required: true
type: str
description:
- DPU BMC IP Address.
username:
type: str
description:
- DPU BMC username.
password:
type: str
description:
- DPU BMC user password.
https_port:
type: int
description:
- DPU BMC port.
default: 443
5 changes: 5 additions & 0 deletions roles/get_bmc_facts/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.

---
# defaults file for get_bmc_facts

https_port: 443

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/get_bmc_facts/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use get_bmc_facts_ as a prefix. (vars: https_port)
28 changes: 28 additions & 0 deletions roles/get_bmc_facts/meta/argument_specs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.
---
argument_specs:
main:
version_added: "1.0.0"
short_description: Gathers facts about DPU BMC Inventory.
description:
- This role Gathers facts about DPU BMC software and firmware Inventory.
options:
hostname:
required: true
type: str
description:
- DPU BMC IP Address.
username:
type: str
description:
- DPU BMC username.
password:
type: str
description:
- DPU BMC user password.
https_port:
type: int
description:
- DPU BMC port.
default: 443
5 changes: 5 additions & 0 deletions roles/update_bmc_password/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2022-2024 Dell Inc, or its subsidiaries.

---
# defaults file for update_bmc_password

https_port: 443

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.15)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.16)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.11, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.9, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)

Check warning on line 7 in roles/update_bmc_password/defaults/main.yml

View workflow job for this annotation

GitHub Actions / Ansible lint (3.10, stable-2.14)

var-naming[no-role-prefix]

Variables names from within roles should use update_bmc_password_ as a prefix. (vars: https_port)
18 changes: 18 additions & 0 deletions roles/update_bmc_password/meta/argument_specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,24 @@ argument_specs:
description:
- Update Password of DPU BMC for a given user.
options:
hostname:
required: true
type: str
description:
- DPU BMC IP Address.
username:
type: str
description:
- DPU BMC username.
password:
type: str
description:
- DPU BMC user password.
https_port:
type: int
description:
- DPU BMC port.
default: 443
update_bmc_password_login_name:
type: str
description: DPU BMC username to change.
Expand Down

0 comments on commit 0780890

Please sign in to comment.