This repository has been archived by the owner on Jan 25, 2019. It is now read-only.
pkg/helm: adding manifest diff logging #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasbro17
reviewed
Oct 29, 2018
| text := diff.Text | ||
| switch diff.Type { | ||
| case diffmatchpatch.DiffInsert: | ||
| _, _ = buff.WriteString("\x1b[32m") |
There was a problem hiding this comment.
@AlexNPavel I recall we had some issues in seeing the colorized output while doing a diff for our unit tests. Do you remember if that was specific to what type of shell you use.
@joelanford Are you able to see the colorized output properly when you get the logs? Can you share a sample output?
There was a problem hiding this comment.
Most shells should support colors. Some shells may not, and this print out [32m in the output. This shouldn't really happen though, as almost all shells support color (or at least ignore the entire block defining the color, which is fine here since we are doing line based diffs)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adding diff output to operator logs to show resource changes for release installations, updates, and uninstallations.
Motivation for change
See #52. One of the suggestions is to help users troubleshoot and better understand the changes that are made to resources in their cluster as a result of changes to the CRs watched by the operator.