Add cache entries for reshape ops in SPMD. #21579
Open
+101
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache entries for reshape ops in SPMD.
We may have two compatible sharding pairs when handling reshape. If we have two pairs, we use the first one. We can still use the second one to add as a sharding cache. Given the following reshape,
there are two compatible sharding pairs
Before this change, we only add 1.1 and 1.2. This change also adds 2.1 as a reshard cache, which can be used directly without reshard the result of 1.2. If the cache is not used, it will be removed by DCE pass.
Given the following input
Before this change, we have "expensive" all-gather
With this change, we replace reshard with reshape