forked from openwrt/routing
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize official source code #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous build errors with v5 have been fixed. This version builds packages as a normal user instead of as root. Signed-off-by: Jeffery To <[email protected]> (cherry picked from commit e2d72c5)
Update checkout and upload-artifact action to v3 to mute nodejs deprecation warning. Signed-off-by: Christian Marangi <[email protected]> (cherry picked from commit 52570d4) (cherry picked from commit 5d87b95)
Enable `errexit` and `nounset` [POSIX shell options][1] in `.github/workflows/entrypoint.sh` so that the script fails if any command within the script fails. [1]: https://pubs.opengroup.org/onlinepubs/9699919799//utilities/V3_chap02.html#set Reported-by: Marius Dinu <[email protected]> Fixes: openwrt/packages#19953 Signed-off-by: Alois Klink <[email protected]> (cherry picked from commit 03ca072)
Since this file was taken from packages repository, it tries to compile packages from that repository as fallback if changes are not detected. Let's change these packages to some, which are present in this repository, so they will be compiled as test. Signed-off-by: Josef Schlehofer <[email protected]> (cherry picked from commit c9a8f2d)
Currently, the package run-test phase will fail for PRs that only add/update host-only packages, as no target packages (*.ipk) are built. This checks if any target packages are built before attempting the run-tests. Signed-off-by: Jeffery To <[email protected]> (cherry picked from commit 299ee2b)
To test each package, the CI-built target package (ipk) file is installed, but currently the target package's dependencies are installed from the standard opkg feeds. There are cases when the CI-built target packages should be installed/tested together: * If a pull request contains several new packages that depend on each other, the test step will fail as the new dependencies cannot be found in the current packages feed. * If a pull request upgrades a source package that builds several target packages that depend on each other, the test step may fail due to the version/ABI mismatch between a newer target package and the older dependencies installed from the packages feed. This sets up a local feed for the CI-built packages so that dependencies are also installed from the same set of packages. Signed-off-by: Jeffery To <[email protected]> (cherry picked from commit f818fe7)
- Add PKG_LICENSE_FILES - Use two spaces instead of tabs Signed-off-by: Josef Schlehofer <[email protected]> (cherry picked from commit c64e02c)
Signed-off-by: Moritz Warning <[email protected]> (cherry picked from commit 91e0790)
OpenNDS lists nodogsplash a conflict as well. This causes a circular reference that is not allowed. Signed-off-by: Moritz Warning <[email protected]> (cherry picked from commit 967dde5)
Fix a buffer overflow in case the query string is too long. Signed-off-by: Moritz Warning <[email protected]> (cherry picked from commit fe1c67f)
Signed-off-by: Moritz Warning <[email protected]> (cherry picked from commit 2a725e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me / @<github-user> (find it by checking history of the package Makefile)
Compile tested: (put here arch, model, OpenWrt version)
Run tested: (put here arch, model, OpenWrt version, tests done)
Description: