Synchronize official source code #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strength gauge is now displayed. Appended dBm measurement also. Corrected some labels. Closes openwrt#6147 Signed-off-by: Paul Donald <[email protected]> (cherry picked from commit 723eb38)
The previous implementation of binding the protocol validation to the name validation caused problems when creating a new interface where an already existing interface had the new one's protocol as its name, as the protocol would be used when validating if an interface of that name already existed. Consider the following case: 1. Interface 'gre' with protocol PPPoE is created 2. Interface 'foo' with protocol GRE tunnel over IPv4 (which resolves to 'gre') tries to be created Creating interface 'foo' would error out during protocol validation as 'gre' would be passed to the name validation, which in turn would check if an interface with name 'gre' already exists, which it does. Instead of reusing the validation logic, simply trigger the name validation manually as the protocol changes to properly pass the name of the interface instead of the protocol. This also gives the benefit of keeping all error states related to the name contained in the appropriate UI element. Fixes openwrt#7146 Tested-by: Tiago Gaspar <[email protected]> Signed-off-by: Daniel Nilsson <[email protected]> (cherry picked from commit 300961b)
Signed-off-by: Paul Donald <[email protected]> (cherry picked from commit 3aa6087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.