ffmpeg: add swresample and more decoders/parsers to audio-dec variant #25657
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the AAC decoder + demuxer and the AAC, AC3, FLAC, and MPEG Audio parsers, since these seem obviously important for audio decoding. Also add the swresample library, which is quite small and seems plausibly useful for audio decoding. For example, shairport-sync requires it for AirPlay 2 support, so this allows changing shairport-sync's dependency from libffmpeg-full to libffmpeg-audio-dec, which makes for a significant reduction in image size. Signed-off-by: Will Mortensen <[email protected]>
|
I think the original reason for aac’s absence is patents. |
|
@systemcrash: ^ |
|
Decoders and parsers do not require patent licenses. |
|
Thanks for all this -- good work! |
|
hrm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the AAC decoder + demuxer and the AAC, AC3, FLAC, and MPEG Audio parsers, since these seem obviously important for audio decoding.
Also add the swresample library, which is quite small and seems plausibly useful for audio decoding. For example, shairport-sync requires it for AirPlay 2 support, so this allows changing shairport-sync's dependency from libffmpeg-full to libffmpeg-audio-dec, which makes for a significant reduction in image size.
I verified that shairport-sync AirPlay 2 still works correctly with its dependency changed to libffmpeg-audio-dec. (I'll submit a separate PR for that if this is accepted.)
Maintainer: @neheb @BKPepe @thess
Compile/run tested: ramips, Cudy TR1200 v1, OpenWrt 24.10-SNAPSHOT, r28242-1eff737906
CC #22993 @mikebrady @bklang