Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flup: drop package #25630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

flup: drop package #25630

wants to merge 1 commit into from

Conversation

commodo
Copy link
Contributor

@commodo commodo commented Dec 27, 2024

Maintainer: me & @BKPepe
Compile tested: n/a
Run tested: n/a

Latest release on pypi is from 2018
https://pypi.org/project/flup/

The homepage looks outdated (~2005):
https://www.saddi.com/software/flup/

No other package in the feeds uses this.

Time to retire this from the main branch.

commodo added a commit to commodo/packages-abandoned that referenced this pull request Dec 28, 2024
Dropped here:
   openwrt/packages#25630

Signed-off-by: Alexandru Ardelean <[email protected]>
Latest release on pypi is from 2018
   https://pypi.org/project/flup/

The homepage looks outdated (~2005):
   https://www.saddi.com/software/flup/

No other package in the feeds uses this.

Time to retire this from the main branch.

PR for abandoned packages:
   openwrt/packages-abandoned#46

Signed-off-by: Alexandru Ardelean <[email protected]>
@BKPepe
Copy link
Member

BKPepe commented Dec 28, 2024

I checked if I have the python3-flup installed on my Turris router, and indeed, I have it. I am not interested in packaging Python packages for OpenWrt, nor having maintainership for these packages. My priorities have changed, and in my free time, I am trying to review something or send pull requests for packages that I am interested in.

In the past, I asked @turris-cz to step in. However, no further steps were taken by them. It is a question of whether we should remove it if the downstream project uses it for its Web UI 1 and for its Turris Auth 2. I think we can ask someone from the Turris team, e.g., @aleksan4eg again, if they want to have these packages in their own specific feed if they will take maintainership, or if they will drop Flup. Who knows what the next step is going to be? 🤷

Footnotes

  1. https://gitlab.nic.cz/turris/reforis/reforis/-/blob/619ec818a07f4f13f8a42fc13a709c2c02cb0cc8/pyproject.toml#L30

  2. https://gitlab.nic.cz/turris/turris-auth/-/blob/0822bc1195e56d73cfb52e4f974fe33e28563b17/pyproject.toml#L12

@BKPepe BKPepe removed their assignment Dec 28, 2024
@commodo
Copy link
Contributor Author

commodo commented Jan 1, 2025

Well, I would be also fine to keep it.

But since there hasn't been any updates to it (for a while), I am wondering if this is needed, of whether it still works.

I am also trying to cut down a bit of the number of packages I am listed as maintainer; and keep the ones that make sense.

@systemcrash
Copy link
Contributor

In the past, I asked @turris-cz to step in. However, no further steps were taken by them. It is a question of whether we should remove it if the downstream project uses it for its Web UI 1 and for its Turris Auth 2. I think we can ask someone from the Turris team, e.g., @aleksan4eg again, if they want to have these packages in their own specific feed if they will take maintainership, or if they will drop Flup. Who knows what the next step is going to be? 🤷

Remove the package. If they need it, perhaps they can maintain the package. Doesn't hurt to keep it, but isn't our responsibility to maintain it for them.

Is it certain that it's Python3 compatible?

@BKPepe
Copy link
Member

BKPepe commented Jan 9, 2025

Remove the package. If they need it, perhaps they can maintain the package. Doesn't hurt to keep it, but isn't our responsibility to maintain it for them.

They can, right? @shenek do you think that Flup could be replaced in your applications, if not, is it possible that someone from Turris SW distro guys will assign maintainership for this package?

Is it certain that it's Python3 compatible?

Yep, I am. Its working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants