node: Do not use shared `abseil-cpp` #25582

vidplace7 · 2024-12-19T23:38:52Z

Maintainer: @nxhack
Compile tested: OpenWRT One master/snapshot

Description:
Fix nodejs compile errors after the introduction of abseil-cpp in #25565

Extends the existing gyp_tools patch to force v8 to use the bundled (chromium) abseil-cpp.

Resolves #25483

Thanks to @vortexilation for pointing out this issue.

Signed-off-by: Austin Lane <[email protected]>

nxhack · 2024-12-20T00:23:41Z

Hi @vidplace7

Question.

The source code distributed by node.js includes abseil-cpp.

. /deps/v8/third_party/abseil-cpp

It appears to be used in the current package.

. /out/Release/obj.host/v8_abseil
. /out/Release/obj.host/v8_abseil/deps/v8/third_party/abseil-cpp
. /out/Release/obj.host/tools/v8_gypfiles/libv8_abseil.a.ar-file-list
. /out/Release/obj.host/tools/v8_gypfiles/libv8_abseil.a
. /out/Release/obj.target/v8_abseil
. /out/Release/obj.target/v8_abseil/deps/v8/third_party/abseil-cpp
. /out/Release/obj.target/tools/v8_gypfiles/libv8_abseil.a.ar-file-list
. /out/Release/obj.target/tools/v8_gypfiles/libv8_abseil.a

Please tell us why this modification is necessary for this package.

vidplace7 · 2024-12-20T00:27:59Z

@nxhack a shared abseil-cpp package was introduced in #25565, for use in protobuf (and other packages that use the standard abseil-cpp LTS version / don't bundle it themselves).

Without this patch, if the shared abseil-cpp library package is installed to the staging_dir before node is compiled, node (v8) will attempt to use it, and fail spectacularly (as it's a different variant/version).

nxhack · 2024-12-20T00:31:40Z

Understood.
I will now test to see if it builds correctly on all architectures. Please give me some time.

nxhack · 2024-12-20T03:44:11Z

It seems that the host build of node.js fails when abseil-cpp is installed. We will consider a workaround.
It fails regardless of whether or not hostpkg abseil-cpp is installed.

nxhack · 2024-12-20T04:39:47Z

It's a very dirty patch, but it worked!

diff --git a/lang/node/patches/204-v8_gyp.patch b/lang/node/patches/204-v8_gyp.patch
index 8496a7c71..0a12e67b8 100644
--- a/lang/node/patches/204-v8_gyp.patch
+++ b/lang/node/patches/204-v8_gyp.patch
@@ -28,7 +28,7 @@
        'sources': [
          '<(V8_ROOT)/src/init/setup-isolate-full.cc',
        ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
      },  # v8_init
      {
        # This target is used to work around a GCC issue that causes the
@@ -40,7 +40,7 @@
        'include_dirs': [
          '<(SHARED_INTERMEDIATE_DIR)',
          '<(generate_bytecode_output_root)',
-+        '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
++        '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
        ],
        'sources': [
          '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "\\"v8_initializers.*?sources = ")',
@@ -48,7 +48,7 @@
        'toolsets': ['host', 'target'],
        'direct_dependent_settings': {
          'sources': ['<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "v8_compiler_sources = ")'],
-+        'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++        'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
          'conditions': [
            ['v8_target_arch=="ia32"', {
              'sources': [
@@ -57,7 +57,7 @@
        'type': 'static_library',
        'toolsets': ['host', 'target'],
 +      'libraries!':[ '-lcrypto', '-lssl', '-lz', '-lhttp_parser', '-luv', '-lnghttp2', '-lcares' ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
        'dependencies': [
          'generate_bytecode_builtins_list',
          'run_torque',
@@ -65,7 +65,7 @@
          'run_torque',
          'v8_maybe_icu',
        ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
        'conditions': [
          ['(is_component_build and not v8_optimized_debug and v8_enable_fast_mksnapshot) or v8_enable_turbofan==0', {
            'dependencies': [
@@ -99,7 +99,7 @@
        'type': 'executable',
 +      'libraries!':[ '-lcrypto', '-lssl', '-lz', '-lhttp_parser', '-luv', '-lnghttp2', '-lcares' ],
 +      'library_dirs':[ '../../../../staging_dir/hostpkg/share/icu/current/lib' ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
        'dependencies': [
          'v8_base_without_compiler',
          'v8_compiler_for_mksnapshot',
@@ -144,7 +144,7 @@
          'include_dirs': [
            '<(V8_ROOT)/third_party/zlib',
            '<(V8_ROOT)/third_party/zlib/google',
-+          '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
++          '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
          ],
        },
        'defines': [ 'ZLIB_IMPLEMENTATION' ],
@@ -152,7 +152,21 @@
        'include_dirs': [
          '<(V8_ROOT)/third_party/zlib',
          '<(V8_ROOT)/third_party/zlib/google',
-+        '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
++        '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
        ],
        'sources': [
          '<(V8_ROOT)/third_party/zlib/adler32.c',
+@@ -2229,10 +2254,13 @@
+         'ABSEIL_ROOT': '../../deps/v8/third_party/abseil-cpp',
+       },
+       'direct_dependent_settings': {
++        'include_dirs!': [ '<!@(echo "$STAGING_DIR"/usr/include)' ],
+         'include_dirs': [
+           '<(ABSEIL_ROOT)',
++          '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
+         ],
+       },
++      'include_dirs!': [ '<!@(echo "$STAGING_DIR"/usr/include)' ],
+       'include_dirs': [
+         '<(ABSEIL_ROOT)',
+       ],

I will resume testing.

vortexilation · 2024-12-20T06:41:03Z

This PR seems doesn't work but patch above by @nxhack is working.

nxhack · 2024-12-20T22:27:50Z

I have confirmed that it builds and runs on aarch64, arm, i386, x86_64 with my patch applied.

vortexilation · 2024-12-21T04:34:55Z

Hmm, can you please try with glibc on x86_64?

nxhack · 2024-12-21T10:59:28Z

@vortexilation

I am verifying a simplified version of the above patch. musl does not give me any problems at all, but glibc gives me the following error. I will consider a countermeasure.

../deps/v8/third_party/abseil-cpp/absl/container/internal/hashtablez_sampler.cc:75:6: error: no declaration matches 'void absl::lts_20240722::container_internal::HashtablezInfo::PrepareForSampling(int64_t, size_t)'
   75 | void HashtablezInfo::PrepareForSampling(int64_t stride,
      |      ^~~~~~~~~~~~~~
In file included from ../deps/v8/third_party/abseil-cpp/absl/container/internal/hashtablez_sampler.cc:15:
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/container/internal/hashtablez_sampler.h:75:8: note: candidate is: 'void absl::lts_20240722::container_internal::HashtablezInfo::PrepareForSampling(int64_t, size_t, size_t, size_t, uint16_t '
   75 |   void PrepareForSampling(int64_t stride, size_t inline_element_size_value,
      |        ^~~~~~~~~~~~~~~~~~
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/container/internal/hashtablez_sampler.h:66:8: note: 'struct absl::lts_20240722::container_internal::HashtablezInfo' defined here
   66 | struct HashtablezInfo : public profiling_internal::Sample<HashtablezInfo> {
      |        ^~~~~~~~~~~~~~
In file included from ../../../../staging_dir/target-x86_64_glibc/usr/include/absl/container/internal/hashtablez_sampler.h:5 :
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/profiling/internal/sample_recorder.h: In instantiation of 'T* absl::lts_20240722::profiling_internal::SampleRecorder<T>::Register(Targs&& ...) [with Targs = {const long int&, long unsigned int&}; T = absl::lts_20240722::container_internal::HashtablezInfo]':
../deps/v8/third_party/abseil-cpp/absl/container/internal/hashtablez_sampler.cc:124:43:   required from here
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/profiling/internal/sample_recorder.h:210:33: error: no matching function for call to 'absl::lts_20240722::container_internal::HashtablezInfo::PrepareForSampling(const long int&, long unsigned int&)'
  210 |       sample->PrepareForSampling(std::forward<Targs>(args)...);
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/container/internal/hashtablez_sampler.h:75:8: note: candidate:  void absl::lts_20240722::container_internal::HashtablezInfo::PrepareForSampling(int64_t, size_t, size_t, size_t, uint16_t)'
   75 |   void PrepareForSampling(int64_t stride, size_t inline_element_size_value,
      |        ^~~~~~~~~~~~~~~~~~
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/container/internal/hashtablez_sampler.h:75:8: note:   candidate expects 5 arguments, 2 provided
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/profiling/internal/sample_recorder.h: In instantiation of 'T* absl::lts_20240722::profiling_internal::SampleRecorder<T>::PopDead(Targs ...) [with Targs = {long int, long unsigned int}; T = absl::lts_20240722::container_internal::HashtablezInfo]':
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/profiling/internal/sample_recorder.h:196:22:   required from 'T* absl::lts_20240722::profiling_internal::SampleRecorder<T>::Register(Targs&& ...) [with Targs = {const long int&, long unsigned int&}; T = absl::lts_20240722::container_internal::HashtablezInfo]'
../deps/v8/third_party/abseil-cpp/absl/container/internal/hashtablez_sampler.cc:124:43:   required from here
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/profiling/internal/sample_recorder.h:182:29: error: no matching function for call to 'absl::lts_20240722::container_internal::HashtablezInfo::PrepareForSampling(long int, long unsigned int '
  182 |   sample->PrepareForSampling(std::forward<Targs>(args)...);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/container/internal/hashtablez_sampler.h:75:8: note: candidate:  void absl::lts_20240722::container_internal::HashtablezInfo::PrepareForSampling(int64_t, size_t, size_t, size_t, uint16_t)'
   75 |   void PrepareForSampling(int64_t stride, size_t inline_element_size_value,
      |        ^~~~~~~~~~~~~~~~~~
../../../../staging_dir/target-x86_64_glibc/usr/include/absl/container/internal/hashtablez_sampler.h:75:8: note:   candidate expects 5 arguments, 2 provided
make[4]: *** [tools/v8_gypfiles/v8_abseil.host.mk:263: /mnt/glibc/openwrt/build_dir/target-x86_64_glibc/node-v22.11.0/out/Release/obj.host/v8_abseil/deps/v8/third_party/abseil-cpp/absl/container/internal/hashtablez_sampler.o] Error 1

nxhack · 2024-12-21T13:22:48Z

With this patch, glibc seems to be ok.
I will test it again. It will take some time.

diff --git a/lang/node/patches/204-v8_gyp.patch b/lang/node/patches/204-v8_gyp.patch
index 8496a7c71..5dba48a4f 100644
--- a/lang/node/patches/204-v8_gyp.patch
+++ b/lang/node/patches/204-v8_gyp.patch
@@ -28,7 +28,7 @@
        'sources': [
          '<(V8_ROOT)/src/init/setup-isolate-full.cc',
        ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
      },  # v8_init
      {
        # This target is used to work around a GCC issue that causes the
@@ -40,7 +40,7 @@
        'include_dirs': [
          '<(SHARED_INTERMEDIATE_DIR)',
          '<(generate_bytecode_output_root)',
-+        '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
++        '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
        ],
        'sources': [
          '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "\\"v8_initializers.*?sources = ")',
@@ -48,7 +48,7 @@
        'toolsets': ['host', 'target'],
        'direct_dependent_settings': {
          'sources': ['<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "v8_compiler_sources = ")'],
-+        'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++        'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
          'conditions': [
            ['v8_target_arch=="ia32"', {
              'sources': [
@@ -57,7 +57,7 @@
        'type': 'static_library',
        'toolsets': ['host', 'target'],
 +      'libraries!':[ '-lcrypto', '-lssl', '-lz', '-lhttp_parser', '-luv', '-lnghttp2', '-lcares' ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
        'dependencies': [
          'generate_bytecode_builtins_list',
          'run_torque',
@@ -65,7 +65,7 @@
          'run_torque',
          'v8_maybe_icu',
        ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
        'conditions': [
          ['(is_component_build and not v8_optimized_debug and v8_enable_fast_mksnapshot) or v8_enable_turbofan==0', {
            'dependencies': [
@@ -99,7 +99,7 @@
        'type': 'executable',
 +      'libraries!':[ '-lcrypto', '-lssl', '-lz', '-lhttp_parser', '-luv', '-lnghttp2', '-lcares' ],
 +      'library_dirs':[ '../../../../staging_dir/hostpkg/share/icu/current/lib' ],
-+      'include_dirs': [ '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
++      'include_dirs': [ '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)' ],
        'dependencies': [
          'v8_base_without_compiler',
          'v8_compiler_for_mksnapshot',
@@ -144,7 +144,7 @@
          'include_dirs': [
            '<(V8_ROOT)/third_party/zlib',
            '<(V8_ROOT)/third_party/zlib/google',
-+          '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
++          '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
          ],
        },
        'defines': [ 'ZLIB_IMPLEMENTATION' ],
@@ -152,7 +152,15 @@
        'include_dirs': [
          '<(V8_ROOT)/third_party/zlib',
          '<(V8_ROOT)/third_party/zlib/google',
-+        '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
++        '../../deps/v8/third_party/abseil-cpp', '<!@(echo "$STAGING_DIR"/usr/../usr/include)',
        ],
        'sources': [
          '<(V8_ROOT)/third_party/zlib/adler32.c',
+@@ -2228,6 +2253,7 @@
+       'variables': {
+         'ABSEIL_ROOT': '../../deps/v8/third_party/abseil-cpp',
+       },
++      'include_dirs!': [ '<!@(echo "$STAGING_DIR"/usr/include)' ],
+       'direct_dependent_settings': {
+         'include_dirs': [
+           '<(ABSEIL_ROOT)',

vortexilation · 2024-12-21T14:48:06Z

@nxhack
Your first patch is working for me, also the newest one (glibc). Thanks.

nxhack · 2024-12-22T05:35:20Z

I have applied my recent patch and confirmed it works on aarch64, arm, i386, x86_64 and x86_64+glibc.

vidplace7 · 2024-12-24T16:38:26Z

@commodo This change should be reverted, @nxhack's patch #25582 (comment) should be submitted instead. Sorry for the confusion.

commodo · 2024-12-25T07:13:17Z

ok;
apologies for this;

please open a PR for this;
either a revert, or the patch from @nxhack

This reverts commit 9e70d3c. As mentioned here: openwrt#25582 (comment) Signed-off-by: Alexandru Ardelean <[email protected]>

This reverts commit 9e70d3c. As mentioned here: #25582 (comment) Signed-off-by: Alexandru Ardelean <[email protected]>

vortexilation · 2024-12-27T16:35:56Z

@vidplace7 or @nxhack

Please do the honour for submitting the right PR.

nxhack · 2024-12-27T22:28:49Z

Okay. I will work on it.

remake this commit openwrt#25582 Fix nodejs compile errors after the introduction of abseil-cpp in openwrt#25565 Signed-off-by: Hirokazu MORIKAWA <[email protected]>

remake this commit #25582 Fix nodejs compile errors after the introduction of abseil-cpp in #25565 Signed-off-by: Hirokazu MORIKAWA <[email protected]>

node: Do not use shared abseil-cpp

6f17d33

Signed-off-by: Austin Lane <[email protected]>

vidplace7 mentioned this pull request Dec 19, 2024

node: undefined reference to absl::lts_20230802 #25483

Closed

vidplace7 marked this pull request as draft December 20, 2024 15:51

vortexilation mentioned this pull request Dec 22, 2024

Ignore 3rd party compiled abseil-cpp and use current bundled abseil-cpp nodejs/node#56104

Open

commodo marked this pull request as ready for review December 24, 2024 15:44

commodo merged commit 9e70d3c into openwrt:master Dec 24, 2024
14 checks passed

commodo added a commit to commodo/packages that referenced this pull request Dec 26, 2024

Revert "node: Do not use shared abseil-cpp"

f8f3f11

This reverts commit 9e70d3c. As mentioned here: openwrt#25582 (comment) Signed-off-by: Alexandru Ardelean <[email protected]>

commodo added a commit to commodo/packages that referenced this pull request Dec 26, 2024

Revert "node: Do not use shared abseil-cpp"

b8945fd

This reverts commit 9e70d3c. As mentioned here: openwrt#25582 (comment) Signed-off-by: Alexandru Ardelean <[email protected]>

commodo mentioned this pull request Dec 26, 2024

Revert "node: Do not use shared abseil-cpp" #25620

Merged

commodo added a commit that referenced this pull request Dec 26, 2024

Revert "node: Do not use shared abseil-cpp"

031bf6f

This reverts commit 9e70d3c. As mentioned here: #25582 (comment) Signed-off-by: Alexandru Ardelean <[email protected]>

nxhack mentioned this pull request Dec 27, 2024

node: remake - do not use shared abseil-cpp #25631

Merged

1715173329 pushed a commit that referenced this pull request Dec 30, 2024

node: remake - do not use shared abseil-cpp

e617871

remake this commit #25582 Fix nodejs compile errors after the introduction of abseil-cpp in #25565 Signed-off-by: Hirokazu MORIKAWA <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node: Do not use shared `abseil-cpp` #25582

node: Do not use shared `abseil-cpp` #25582

vidplace7 commented Dec 19, 2024

nxhack commented Dec 20, 2024

vidplace7 commented Dec 20, 2024 •

edited

Loading

nxhack commented Dec 20, 2024

nxhack commented Dec 20, 2024 •

edited

Loading

nxhack commented Dec 20, 2024

vortexilation commented Dec 20, 2024

nxhack commented Dec 20, 2024 •

edited

Loading

vortexilation commented Dec 21, 2024

nxhack commented Dec 21, 2024

nxhack commented Dec 21, 2024

vortexilation commented Dec 21, 2024 •

edited

Loading

nxhack commented Dec 22, 2024

vidplace7 commented Dec 24, 2024

commodo commented Dec 25, 2024

vortexilation commented Dec 27, 2024

nxhack commented Dec 27, 2024

node: Do not use shared abseil-cpp #25582

node: Do not use shared abseil-cpp #25582

Conversation

vidplace7 commented Dec 19, 2024

nxhack commented Dec 20, 2024

vidplace7 commented Dec 20, 2024 • edited Loading

nxhack commented Dec 20, 2024

nxhack commented Dec 20, 2024 • edited Loading

nxhack commented Dec 20, 2024

vortexilation commented Dec 20, 2024

nxhack commented Dec 20, 2024 • edited Loading

vortexilation commented Dec 21, 2024

nxhack commented Dec 21, 2024

nxhack commented Dec 21, 2024

vortexilation commented Dec 21, 2024 • edited Loading

nxhack commented Dec 22, 2024

vidplace7 commented Dec 24, 2024

commodo commented Dec 25, 2024

vortexilation commented Dec 27, 2024

nxhack commented Dec 27, 2024

node: Do not use shared `abseil-cpp` #25582

node: Do not use shared `abseil-cpp` #25582

vidplace7 commented Dec 20, 2024 •

edited

Loading

nxhack commented Dec 20, 2024 •

edited

Loading

nxhack commented Dec 20, 2024 •

edited

Loading

vortexilation commented Dec 21, 2024 •

edited

Loading