Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19 #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #19 #20

wants to merge 4 commits into from

Conversation

travs
Copy link

@travs travs commented Sep 16, 2018

No description provided.

@travs travs requested a review from gsarma September 16, 2018 22:07
@gsarma
Copy link
Member

gsarma commented Oct 10, 2018

@travs can you look at @mwatts15 comments in Slack about keeping the outputs? I think he's right that having them will be useful so people can just read the notebook without having to run it locally.

@gsarma
Copy link
Member

gsarma commented Oct 10, 2018

@travs this looks great! One important change, however. The function you wrote display_parameter_evolution keeps track of the parameters in a single run and generates histograms from a given run. What we want (the plot I pinned in Slack) is to run the simulation many times and only retain the final fit parameters. Then we generate a histogram of the final values of all of the different runs. This way we can see how sensitive the fitter is to initial conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants