Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change!] Changed the command to delete_old_radiusbatch_users #294 #295

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

praptisharma28
Copy link
Member

Updated the command. Related to openwisp/openwisp-radius#502 .This change ensures proper functionality and maintains consistency.

Closes #294

@praptisharma28
Copy link
Member Author

praptisharma28 commented Mar 9, 2024

Screenshot from 2024-03-09 20-13-02

Screenshot from 2024-03-09 20-12-50
Attached the screenshots too @nemesifier @pandafy

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @praptisharma28 👍

@praptisharma28
Copy link
Member Author

@nemesifier what corrections are needed to be done here now?

@nemesifier
Copy link
Member

@nemesifier what corrections are needed to be done here now?

Nothing here, just the build on master seems failing, we'll need to resolve that before merging.

@pandafy
Copy link
Member

pandafy commented Mar 22, 2024

@praptisharma28 From the initial impression it looks like a python dependency issue. Look a this line in the logs https://github.com/openwisp/docker-openwisp/pull/295/checks#step:6:1391

@praptisharma28
Copy link
Member Author

@praptisharma28 From the initial impression it looks like a python dependency issue. Look a this line in the logs https://github.com/openwisp/docker-openwisp/pull/295/checks#step:6:1391

Yeah, u r right the error message indicates that the need for netaddr~=0.8 or netaddr~=0.8.0 is not fulfilled, but idk how to resolve it. @pandafy

@nemesifier nemesifier merged commit cbef70d into openwisp:master Apr 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[change] Update command name to delete_old_radiusbatch_users
3 participants