fix: generate atomic string for css properties.

openwebf · Nov 18, 2024 · 6131f5e · 6131f5e
1 parent ee43fb1
commit 6131f5e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/bridge/core/css/parser/css_selector_parser.cc b/bridge/core/css/parser/css_selector_parser.cc
@@ -1766,7 +1766,6 @@ tcb::span<CSSSelector> CSSSelectorParser::ConsumeCompoundSelector(CSSParserToken
   AtomicString namespace_prefix;
   AtomicString element_name;
   const bool has_q_name = ConsumeName(stream, element_name, namespace_prefix);
-  element_name = element_name.LowerASCII();
 
   // A tag name is not valid following a pseudo-element. This can happen for
   // e.g. :::part(x):is(div).

diff --git a/bridge/scripts/code_generator/templates/json_templates/css_properties.cc.tpl b/bridge/scripts/code_generator/templates/json_templates/css_properties.cc.tpl
@@ -38,6 +38,11 @@ const char* <%= class_name %>::GetPropertyName() const {
   return "<%= exposed_property.name %>";
 }
 
+const AtomicString& <%= class_name %>::GetPropertyNameAtomicString() const {
+  thread_local static AtomicString name("<%= exposed_property.name %>");
+  return name;
+}
+
 const char* <%= class_name %>::GetJSPropertyName() const {
   return "<%= lowerCamelCase(exposed_property.name) %>";
 }

diff --git a/bridge/scripts/code_generator/templates/json_templates/css_properties.h.tpl b/bridge/scripts/code_generator/templates/json_templates/css_properties.h.tpl
@@ -71,6 +71,7 @@ class <%= class_name %> final : public <%= property.superclass %> {
  public:
   constexpr <%= class_name %>() : <%= property.superclass %>(<%= ctor_args.join(', ') %>  ) { }
   const char* GetPropertyName() const override;
+  const AtomicString& GetPropertyNameAtomicString() const override;
   const char* GetJSPropertyName() const override;
   <% if(property.alternative) { %>
   CSSPropertyID GetAlternative() const override {