Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: native guest macro for kernel functions #1191
base: main
Are you sure you want to change the base?
feat: native guest macro for kernel functions #1191
Changes from all commits
b6281dd
a3c05df
2e73ba5
02ebf10
4ccfc13
428f520
e52c697
5a06ecf
1190c9c
a8a9474
6e5f0e4
488e172
011f2ee
8e2d074
c190ac0
eebd4c9
7a92cc7
85070ff
d7450a0
cf0b727
e1eef6a
3f173ec
1216e66
ea37590
af22a84
0377dc0
5b3ccca
5e1928c
7685342
53475d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we rename this and you haven't rebased?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No,
new_without_debug_infos_with_option
is a new constructor distinct fromnew_without_debug_infos
that takesOption<Instruction<F>>
instead ofInstruction<F>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I was in favor of making
without_debug_infos
the default and hence remove it from function names in general