New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add iterator-based for loops #1176

Open

yi-sun wants to merge 37 commits into native-cleanup from feat/optimize-for-loop

+808 −303

Collaborator

yi-sun commented Jan 6, 2025 •

edited

Loading

Closes INT-2930, INT-2946

yi-sun added run-benchmark run-benchmark-e2e labels

This comment has been minimized.

Sign in to view

yi-sun force-pushed the native-cleanup branch from aecb173 to 0103e35 Compare

January 7, 2025 00:11

yi-sun force-pushed the feat/optimize-for-loop branch from a8c0bcc to 165c11c Compare

January 7, 2025 00:39

yi-sun force-pushed the native-cleanup branch from 0103e35 to a9d4756 Compare

January 7, 2025 04:01

yi-sun force-pushed the feat/optimize-for-loop branch from 6d8afc2 to f69afb5 Compare

January 7, 2025 04:05

yi-sun removed the run-benchmark-e2e label

This comment has been minimized.

Sign in to view

yi-sun force-pushed the native-cleanup branch from a9d4756 to 71939d1 Compare

January 7, 2025 05:34

yi-sun force-pushed the feat/optimize-for-loop branch from 1f9f911 to b242cd7 Compare

January 7, 2025 05:35

This comment has been minimized.

Sign in to view

yi-sun force-pushed the native-cleanup branch from 71939d1 to 6c9908a Compare

January 8, 2025 05:36

yi-sun force-pushed the feat/optimize-for-loop branch from b242cd7 to e6b8852 Compare

January 8, 2025 05:37

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

yi-sun added the run-benchmark-e2e label

yi-sun marked this pull request as ready for review

January 8, 2025 08:42

yi-sun changed the title ~~wip: optimize for loops~~ feat: add iterator-based for loops

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

yi-sun force-pushed the native-cleanup branch from 6c9908a to 1d7e7e2 Compare

January 9, 2025 04:24

yi-sun force-pushed the feat/optimize-for-loop branch from 24c5898 to f92aea1 Compare

January 9, 2025 04:24

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

yi-sun added 23 commits

January 10, 2025 02:23


          fix: lint

6533f8d


          feat: add ZipFor and zipped_iter

053a4ee


          fix: lint

5d72e21


          feat: implement zipped_iter

7dc4557


          fix: faulty assert

8c27cdf


          fix: read

f71efd7


          fix: lint

9266fba


          fix: lint

6851b5a


          fix: vec

9d9c5c4


          feat: add more zipped_iter

9b4cc0e


          feat: optimize verify_batch

f85ae11


          fix: use first array for zipped_iter

c9aa05e


          feat: add zipped_iter to hint

45134ad


          chore: remove print

84c9d75


          feat: optimize hint_words

8e8b062


          fix: lifetime issues

2e68d6e


          chore: add comment with example

f5cc632


          feat: use square-and-multiply for exp_reverse_bits_len

0aff4b0


          fix: input size for exp_reverse_bits_len

46ddb6b


          fix: slice and shift for V::size_of() greater than 1, optimization

392355b


          fix: replace incorrectly removed side effect

beae4ce


          feat: optimize adds

2d5a26e


          feat: optimize for loops in duplex challenger

7d8670b

yi-sun force-pushed the feat/optimize-for-loop branch from 62c5f64 to 7d8670b Compare

January 10, 2025 07:32

yi-sun requested review from zlangley, nyunyunyunyu and TlatoaniHJ

January 10, 2025 07:35

yi-sun commented

View reviewed changes

extensions/native/compiler/src/ir/collections.rs

@@ @@ -134,7 +133,7 @@ impl<C: Config, V: MemVariable<C>> Array<C, V> { @@
                               }
                               let slice_len = builder.eval(end - start);
-                              let address = builder.eval(ptr.address + start);
+                              let address = builder.eval(ptr.address + start * RVar::from(V::size_of()));

Collaborator Author

yi-sun Jan 10, 2025

I believe this fixes a previous bug, please check.

yi-sun commented

View reviewed changes

extensions/native/compiler/src/ir/collections.rs

@@ @@ -78,10 +78,9 @@ impl<C: Config, V: MemVariable<C>> Array<C, V> { @@
                               }
                           }
                           Self::Dyn(ptr, len) => {
-                              assert_eq!(V::size_of(), 1, "only support variables of size 1");

Collaborator Author

yi-sun Jan 10, 2025

I'm not sure why this restriction was previously present, as it seems easily removed on L83 below.

github-actions bot commented Jan 10, 2025

group	app.proof_time_ms	app.cycles	app.cells_used	leaf.proof_time_ms	leaf.cycles	leaf.cells_used
verify_fibair	(-141 [-3.7%]) 3,653	(+3621 [+0.5%]) 749,954	(-2594710 [-8.6%]) 27,418,604	-	-	-
fibonacci_program	(+14 [+0.2%]) 6,117	1,500,137	51,505,102	(-907 [-5.9%]) 14,359	(+37398 [+1.2%]) 3,209,412	(-9820651 [-7.6%]) 119,044,836
regex_program	(-97 [-0.5%]) 18,439	4,190,904	165,028,173	(-937 [-3.1%]) 29,736	(-408670 [-6.3%]) 6,111,736	(-32503883 [-11.2%]) 258,768,896
fib_e2e	42,927	12,000,137	410,820,430	87,256	19,214,580	710,044,829
ecrecover_program	2,602	285,401	15,092,297	(-3079 [-7.2%]) 39,841	(-774463 [-8.0%]) 8,888,841	(-52733556 [-12.0%]) 387,824,820

Commit: 7d8670b

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmark run-benchmark-e2e