-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] AsyncSubtensor (Part 4) #2410
Merged
roman-opentensor
merged 9 commits into
staging
from
tests/roman/async-unti-tests-part-4
Nov 13, 2024
Merged
[Tests] AsyncSubtensor (Part 4) #2410
roman-opentensor
merged 9 commits into
staging
from
tests/roman/async-unti-tests-part-4
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-opentensor
changed the base branch from
staging
to
tests/roman/async-unti-tests-part-3
November 13, 2024 02:50
roman-opentensor
changed the title
[Tests] AsyncSubtensor (Part 3)
[Tests] AsyncSubtensor (Part 4)
Nov 13, 2024
camfairchild
previously approved these changes
Nov 13, 2024
thewhaleking
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's log instead of print
Base automatically changed from
tests/roman/async-unti-tests-part-3
to
staging
November 13, 2024 16:32
roman-opentensor
dismissed
camfairchild’s stale review
November 13, 2024 16:32
The base branch was changed.
…Subtensor.neurons_lite`
…unti-tests-part-4 # Conflicts: # tests/unit_tests/test_async_subtensor.py
thewhaleking
approved these changes
Nov 13, 2024
roman-opentensor
added a commit
that referenced
this pull request
Nov 13, 2024
* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * ruff * move out `_decode_hex_identity_dict` from inner function * added tests until `AsyncSubtensor.query_identity` * added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * fix * ruff
roman-opentensor
added a commit
that referenced
this pull request
Nov 13, 2024
* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * ruff * move out `_decode_hex_identity_dict` from inner function * added tests until `AsyncSubtensor.query_identity` * added tests until `AsyncSubtensor.get_hotkey_owner` * Handle new PasswordError from btwallet (#2406) * Handles new PasswordError from btwallet. * Ruff, docstrings. * Fixes hotkey unlock rather than coldkey * Added unit test. * Added unit test. Add integration test. * Removed coldkeypub * Opinions. * More tests * grammar * Update test_utils.py * bump up btwallet version * fix wording * fix wording * Update tests/unit_tests/utils/test_utils.py Co-authored-by: Cameron Fairchild <[email protected]> --------- Co-authored-by: Roman <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: Cameron Fairchild <[email protected]> * [Tests] AsyncSubtensor (Part 4) (#2410) * added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * ruff * move out `_decode_hex_identity_dict` from inner function * added tests until `AsyncSubtensor.query_identity` * added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * fix * ruff --------- Co-authored-by: Benjamin Himes <[email protected]> Co-authored-by: Cameron Fairchild <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.