Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] AsyncSubtensor (Part 4) #2410

Merged
merged 9 commits into from
Nov 13, 2024

Conversation

roman-opentensor
Copy link
Contributor

No description provided.

@roman-opentensor roman-opentensor requested a review from a team November 13, 2024 02:49
@roman-opentensor roman-opentensor self-assigned this Nov 13, 2024
@roman-opentensor roman-opentensor changed the base branch from staging to tests/roman/async-unti-tests-part-3 November 13, 2024 02:50
@roman-opentensor roman-opentensor changed the title [Tests] AsyncSubtensor (Part 3) [Tests] AsyncSubtensor (Part 4) Nov 13, 2024
@roman-opentensor roman-opentensor marked this pull request as ready for review November 13, 2024 02:51
camfairchild
camfairchild previously approved these changes Nov 13, 2024
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's log instead of print

bittensor/core/async_subtensor.py Outdated Show resolved Hide resolved
bittensor/core/async_subtensor.py Outdated Show resolved Hide resolved
Base automatically changed from tests/roman/async-unti-tests-part-3 to staging November 13, 2024 16:32
@roman-opentensor roman-opentensor dismissed camfairchild’s stale review November 13, 2024 16:32

The base branch was changed.

@roman-opentensor roman-opentensor merged commit 8aefb55 into staging Nov 13, 2024
23 checks passed
@roman-opentensor roman-opentensor deleted the tests/roman/async-unti-tests-part-4 branch November 13, 2024 17:07
roman-opentensor added a commit that referenced this pull request Nov 13, 2024
* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite`

* ruff

* move out `_decode_hex_identity_dict` from inner function

* added tests until `AsyncSubtensor.query_identity`

* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite`

* fix

* ruff
roman-opentensor added a commit that referenced this pull request Nov 13, 2024
* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite`

* ruff

* move out `_decode_hex_identity_dict` from inner function

* added tests until `AsyncSubtensor.query_identity`

* added tests until `AsyncSubtensor.get_hotkey_owner`

* Handle new PasswordError from btwallet (#2406)

* Handles new PasswordError from btwallet.

* Ruff, docstrings.

* Fixes hotkey unlock rather than coldkey

* Added unit test.

* Added unit test. Add integration test.

* Removed coldkeypub

* Opinions.

* More tests

* grammar

* Update test_utils.py

* bump up btwallet version

* fix wording

* fix wording

* Update tests/unit_tests/utils/test_utils.py

Co-authored-by: Cameron Fairchild <[email protected]>

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>

* [Tests] AsyncSubtensor (Part 4) (#2410)

* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite`

* ruff

* move out `_decode_hex_identity_dict` from inner function

* added tests until `AsyncSubtensor.query_identity`

* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite`

* fix

* ruff

---------

Co-authored-by: Benjamin Himes <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants