Do not throw on wrong password input #2237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewhaleking
approved these changes
Aug 30, 2024
|
Black check isn't passing on CI |
This should go away. @roman-opentensor can you update the tests for this branch to use |
thewhaleking
requested changes
Sep 3, 2024
| except (InvalidSignature, InvalidKey, InvalidToken): | ||
| raise bittensor.KeyFileError("Invalid password") | ||
| except (InvalidSignature, InvalidKey, InvalidToken, AnsibleVaultError): | ||
| print("Wrong password, try again"); |
| password = None | ||
|
|
||
| except Exception as e: | ||
| if "Decryption failed. Ciphertext failed verification" in str(e): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user inputs a wrong password to unlock the wallet, bittensor throws and all user input is lost. This PR fixes this issue.