Fix: IP is packed with port #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gus-opentensor
approved these changes
Jun 3, 2024
gus-opentensor
added a commit
that referenced
this pull request
Jun 3, 2024
Fix: IP is packed with port
gus-opentensor
added a commit
that referenced
this pull request
Jun 4, 2024
Fix: IP is packed with port
This was referenced Jun 5, 2024
camfairchild
added a commit
that referenced
this pull request
Jun 5, 2024
gus-opentensor
added a commit
that referenced
this pull request
Jun 5, 2024
Fix: IP is packed with port
gus-opentensor
pushed a commit
that referenced
this pull request
Jun 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
The IP is packed with the port. This is a temporary fix until the underlying issue is fixed in Subtensor. This fix ensures that Bittensor handles all versions of IPs consistently and maintains compatibility across versions.
Description of the Change
The change corrects the unpacking logic for encoded IP and port values. The function now accurately extracts the IP address and port from the encoded integer, correctly distinguishing between IPv4 and IPv6 addresses.
Alternate Designs
Other alternatives considered included:
Possible Drawbacks
None that I can think of, since it fallbacks to the old method if it is not encoded.
Release Notes
Fixed an issue with unpacking encoded IP and port values.