Hilary 2022 03 14 #470
Hilary 2022 03 14 #470
Conversation
| @@ -148,6 +148,7 @@ dependencies { | |||
| exclude group: 'com.android.support', module: 'design' | |||
| exclude group: 'io.ona.rdt-capture', module: 'lib' | |||
| exclude group: 'com.google.guava', module: 'guava' | |||
| exclude group: 'com.github.raihan-mpower', module: 'FancyAlertDialog-Android' | |||
There was a problem hiding this comment.
It seems that this might affect the app APK build or cause runtime exceptions.
Is this animation part of the test?
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Is this animation part of the test?
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <translate | |||
There was a problem hiding this comment.
Is this animation part of the test?
There was a problem hiding this comment.
no, but the library was not building without those.
|
|
||
| @Test | ||
| public void testDatabaseQueryIsCreatedWithTheCorrectArgumentInGetFamilyNamePhone(){ | ||
| String baseEntityId = "4b3e6408-0549-470a-b24a-82ac71180a30"; |
There was a problem hiding this comment.
If this test covers the following lines https://github.com/opensrp/opensrp-client-chw-core/blob/master/opensrp-chw-core/src/main/java/org/smartregister/chw/core/repository/MalariaRegisterRepository.java#L42-L51, add an assertion for this also since this will not longer be covered having been already marked as code covered by tests but not actually tested
…-chw-core into hilary-2022-03-14
No description provided.