Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-21124: Remove OSCI jobs that were moved to GHA #47012

Conversation

BradLugo
Copy link
Contributor

@BradLugo BradLugo commented Dec 21, 2023

Description

These changes remove scanner's non-e2e test OpenShift CI jobs that were moved to GitHub Actions.
See stackrox/scanner#1347 for the GitHub Actions changes.

/hold
/uncc

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 21, 2023
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@BradLugo BradLugo force-pushed the blugo/ROX-21124-remove-scanner-jobs branch from 1359a9d to a7da6b4 Compare December 21, 2023 08:24
@BradLugo BradLugo changed the title Draft: WIP ROX-21124: Remove OSCI jobs that were moved to GHA Dec 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 21, 2023

@BradLugo: This pull request references ROX-21124 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/hold
/uncc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BradLugo BradLugo marked this pull request as ready for review December 21, 2023 08:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 21, 2023

@BradLugo: This pull request references ROX-21124 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Description

These changes remove scanner's non-e2e test OpenShift CI jobs that were moved to GitHub Actions.
See stackrox/scanner#1347 for the GitHub Actions changes.

/hold
/uncc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BradLugo
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@BradLugo, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag stackrox/apollo-ci:scanner-test-0.3.61 to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@BradLugo BradLugo force-pushed the blugo/ROX-21124-remove-scanner-jobs branch from a7da6b4 to a639309 Compare December 21, 2023 08:58
@BradLugo
Copy link
Contributor Author

/pj-rehearse

@BradLugo BradLugo force-pushed the blugo/ROX-21124-remove-scanner-jobs branch from a639309 to aac61de Compare December 21, 2023 09:35
@BradLugo
Copy link
Contributor Author

/pj-rehearse

@BradLugo
Copy link
Contributor Author

/unhold
/cc @gavin-stackrox @RTann

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
image_stream_tag:
name: apollo-ci
namespace: stackrox
tag: stackrox-test-0.3.61
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't mirror scanner-test - should we?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't mirror scanner-test - should we?

I'd assume it is necessary as that is what the current environment uses via Dockerfile.build_root.
That has to be a separate PR i.e. it needs to be mirrored before it can be used here.

@BradLugo
Copy link
Contributor Author

A note for reviewers: all the jobs removed here should be in stackrox/scanner#1347

@BradLugo
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@BradLugo BradLugo force-pushed the blugo/ROX-21124-remove-scanner-jobs branch from 56bcc68 to ed7695a Compare December 21, 2023 20:13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this and the other jobs files were automated changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct

requests:
cpu: 2000m
memory: 4000Mi
- as: sanity-check-vuln-updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this migrated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should've been moved in this commit: stackrox/scanner@c0eecec

requests:
cpu: 2000m
memory: 4000Mi
- as: merge-upload-dumps-for-downstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this migrated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should've been moved in this commit: stackrox/scanner@97d5f4e

requests:
cpu: 2000m
memory: 4000Mi
- as: merge-upload-dumps-for-embedding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this migrated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should've been moved in this commit: stackrox/scanner@97d5f4e

@BradLugo
Copy link
Contributor Author

/unhold

@BradLugo
Copy link
Contributor Author

/pj-rehearse

@BradLugo BradLugo force-pushed the blugo/ROX-21124-remove-scanner-jobs branch from ed7695a to 4838d39 Compare January 9, 2024 17:39
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@BradLugo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-scanner-master-e2e-tests stackrox/scanner presubmit Ci-operator config changed
pull-ci-stackrox-scanner-master-scale-tests stackrox/scanner presubmit Ci-operator config changed
pull-ci-stackrox-scanner-master-slim-e2e-tests stackrox/scanner presubmit Ci-operator config changed
periodic-ci-stackrox-scanner-master-hourly-e2e-tests N/A periodic Ci-operator config changed
periodic-ci-stackrox-scanner-master-hourly-slim-e2e-tests N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@BradLugo
Copy link
Contributor Author

BradLugo commented Jan 9, 2024

/pj-rehearse

@gavin-stackrox
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@RTann
Copy link
Contributor

RTann commented Jan 10, 2024

/lgtm

@RTann
Copy link
Contributor

RTann commented Jan 10, 2024

/pj-rehearse periodic-ci-stackrox-scanner-master-hourly-e2e-tests
/pj-rehearse pull-ci-stackrox-scanner-master-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BradLugo, gavin-stackrox, RTann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RTann
Copy link
Contributor

RTann commented Jan 10, 2024

/meowvie

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@RTann: cat image

In response to this:

/meowvie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RTann
Copy link
Contributor

RTann commented Jan 10, 2024

/pj-rehearse pull-ci-stackrox-scanner-master-e2e-tests

@RTann
Copy link
Contributor

RTann commented Jan 10, 2024

/meow

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@RTann: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@BradLugo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-stackrox-scanner-master-hourly-e2e-tests 8027fd1 link unknown /pj-rehearse periodic-ci-stackrox-scanner-master-hourly-e2e-tests
ci/rehearse/stackrox/scanner/master/e2e-tests 8027fd1 link unknown /pj-rehearse pull-ci-stackrox-scanner-master-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RTann
Copy link
Contributor

RTann commented Jan 10, 2024

@BradLugo I think we can ignore the two failing rehearsals

@BradLugo
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3f8be67 into openshift:master Jan 10, 2024
21 of 23 checks passed
robpblake pushed a commit to robpblake/release that referenced this pull request Jan 11, 2024
* [makefile] Fix template-allowlist on ARM (openshift#44276)

Container engine is mising the platform flag and hence
the step fails on ARM machines.

This PR adds the appropraite flags.

Signed-off-by: black-dragon74 <[email protected]>

* add QE catalog source for optional operator testing (openshift#43539)

* regenerate nutanix jobs (openshift#46736)

* make ci-operator-config (openshift#46931)

* ROX-21124: Remove OSCI jobs that were moved to GHA

Signed-off-by: Brad Lugo <[email protected]>

* Change build_root to use scanner's rox-ci image

Signed-off-by: Brad Lugo <[email protected]>

* make update after rebasing

---------

Signed-off-by: black-dragon74 <[email protected]>
Signed-off-by: Brad Lugo <[email protected]>
Co-authored-by: Niraj Yadav <[email protected]>
Co-authored-by: Jian Zhang <[email protected]>
Co-authored-by: Danilo Gemoli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants