-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-21124: Remove OSCI jobs that were moved to GHA #47012
ROX-21124: Remove OSCI jobs that were moved to GHA #47012
Conversation
Skipping CI for Draft Pull Request. |
1359a9d
to
a7da6b4
Compare
@BradLugo: This pull request references ROX-21124 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@BradLugo: This pull request references ROX-21124 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/pj-rehearse |
a7da6b4
to
a639309
Compare
/pj-rehearse |
a639309
to
aac61de
Compare
/pj-rehearse |
/unhold |
image_stream_tag: | ||
name: apollo-ci | ||
namespace: stackrox | ||
tag: stackrox-test-0.3.61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't mirror scanner-test - should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't mirror scanner-test - should we?
I'd assume it is necessary as that is what the current environment uses via Dockerfile.build_root.
That has to be a separate PR i.e. it needs to be mirrored before it can be used here.
A note for reviewers: all the jobs removed here should be in stackrox/scanner#1347 |
aac61de
to
6c1e863
Compare
/hold |
56bcc68
to
ed7695a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this and the other jobs
files were automated changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct
requests: | ||
cpu: 2000m | ||
memory: 4000Mi | ||
- as: sanity-check-vuln-updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this migrated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should've been moved in this commit: stackrox/scanner@c0eecec
requests: | ||
cpu: 2000m | ||
memory: 4000Mi | ||
- as: merge-upload-dumps-for-downstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this migrated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should've been moved in this commit: stackrox/scanner@97d5f4e
requests: | ||
cpu: 2000m | ||
memory: 4000Mi | ||
- as: merge-upload-dumps-for-embedding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this migrated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should've been moved in this commit: stackrox/scanner@97d5f4e
/unhold |
/pj-rehearse |
Container engine is mising the platform flag and hence the step fails on ARM machines. This PR adds the appropraite flags. Signed-off-by: black-dragon74 <[email protected]>
Signed-off-by: Brad Lugo <[email protected]>
Signed-off-by: Brad Lugo <[email protected]>
ed7695a
to
4838d39
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse |
/lgtm |
/lgtm |
/pj-rehearse periodic-ci-stackrox-scanner-master-hourly-e2e-tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BradLugo, gavin-stackrox, RTann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/meowvie |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/pj-rehearse pull-ci-stackrox-scanner-master-e2e-tests |
/meow |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@BradLugo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@BradLugo I think we can ignore the two failing rehearsals |
/pj-rehearse ack |
3f8be67
into
openshift:master
* [makefile] Fix template-allowlist on ARM (openshift#44276) Container engine is mising the platform flag and hence the step fails on ARM machines. This PR adds the appropraite flags. Signed-off-by: black-dragon74 <[email protected]> * add QE catalog source for optional operator testing (openshift#43539) * regenerate nutanix jobs (openshift#46736) * make ci-operator-config (openshift#46931) * ROX-21124: Remove OSCI jobs that were moved to GHA Signed-off-by: Brad Lugo <[email protected]> * Change build_root to use scanner's rox-ci image Signed-off-by: Brad Lugo <[email protected]> * make update after rebasing --------- Signed-off-by: black-dragon74 <[email protected]> Signed-off-by: Brad Lugo <[email protected]> Co-authored-by: Niraj Yadav <[email protected]> Co-authored-by: Jian Zhang <[email protected]> Co-authored-by: Danilo Gemoli <[email protected]>
Description
These changes remove scanner's non-e2e test OpenShift CI jobs that were moved to GitHub Actions.
See stackrox/scanner#1347 for the GitHub Actions changes.
/hold
/uncc