OCPBUGS-30149: Revert "common.yaml: enable cliwrap"

[jlebon]

This reverts commit ff686c6.

With cliwrap, rpm-ostree runs rpm with less privileges. We special-case --query, so e.g. rpm -qf still runs with dropped privileges.

But anyway, we actually want to reduce this to wrapping just dnf for now (see discussions in
coreos/fedora-coreos-config#2887).

Resolves: https://issues.redhat.com/browse/OCPBUGS-30149

[jmarrero]

/lgtm
/approve

[jlebon]

While CI is running on this, let me sanity-check that's what we're hitting in https://issues.redhat.com/browse/OCPBUGS-30149.
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlebon,jmarrero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlebon]

Yup, confirmed:

[root@cosa-devsh ~]# rpm -qf /root/test
error: file /root/test: Permission denied
[root@cosa-devsh ~]# /usr/libexec/rpm-ostree/wrapped/rpm -qf /root/test
error: file /root/test: No such file or directory

/hold cancel

I'll add a test for this as part of coreos/fedora-coreos-config#2887 that'll be shared with FCOS.

[jlebon]

It's interesting though; it seems the EPERM only shows up when querying a file that doesn't exist. Otherwise, it works as usual. E.g.:

[root@cosa-devsh ~]# rpm -qf /etc/audit/rules.d/audit.rules
audit-3.1.2-2.el9.x86_64
[root@cosa-devsh ~]# rpm -qf /etc/audit/rules.d/enoent
error: file /etc/audit/rules.d/enoent: Permission denied

So even with this, it's possible that the MCO might still get an error (but this time about the file not existing) which wouldn't be related to this change.

[mike-nguyen]

On the previous working build it gives us the correct error when querying for a file that doesn't exist.

[root@cosa-devsh ~]# rpm -qf /etc/audit/rules.d/enoent
error: file /etc/audit/rules.d/enoent: No such file or directory

[mike-nguyen]

/retitle OCPBUGS-30149: Revert "common.yaml: enable cliwrap"

[openshift-ci-robot]

@jlebon: This pull request references Jira Issue OCPBUGS-30149, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit ff686c6.

With cliwrap, rpm-ostree runs rpm with less privileges. We special-case --query, so e.g. rpm -qf still runs with dropped privileges.

But anyway, we actually want to reduce this to wrapping just dnf for now (see discussions in
coreos/fedora-coreos-config#2887).

Resolves: https://issues.redhat.com/browse/OCPBUGS-30149

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mike-nguyen]

/jira refresh

[openshift-ci-robot]

@mike-nguyen: This pull request references Jira Issue OCPBUGS-30149, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jlebon: Jira Issue OCPBUGS-30149: All pull requests linked via external trackers have merged:

• openshift/os#1455

Jira Issue OCPBUGS-30149 has been moved to the MODIFIED state.

In response to this:

This reverts commit ff686c6.

With cliwrap, rpm-ostree runs rpm with less privileges. We special-case --query, so e.g. rpm -qf still runs with dropped privileges.

But anyway, we actually want to reduce this to wrapping just dnf for now (see discussions in
coreos/fedora-coreos-config#2887).

Resolves: https://issues.redhat.com/browse/OCPBUGS-30149

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sinnykumari]

So even with this, it's possible that the MCO might still get an error (but this time about the file not existing) which wouldn't be related to this change.

Interesting, from the bug /etc/audit/rules.d/mco-audit-quiet-containers.rules do exist on the node and rpm -qf gives permission denied error. We will get to know better after MCO code runs with the fix.