Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci-lint and config #4762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update golangci-lint and config #4762

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

We now also stop vendoring the whole linter and install it by using the recommended way. The config has been updated to not report anything new.

@saschagrunert
Update golangci-lint and config
200763b 
We now also stop vendoring the whole linter and install it by using the
recommended way. The config has been updated to not report anything new.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@saschagrunert saschagrunert changed the title WIP: Update golangci-lint and config Update golangci-lint and config Dec 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@saschagrunert
Copy link
Member Author

@QiWang19 @rphillips @haircommander PTAL

@haircommander
Copy link
Member

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander, saschagrunert
Once this PR has been reviewed and has the lgtm label, please assign dkhater-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor

lgtm

@saschagrunert
Copy link
Member Author

/retest

almost green.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@saschagrunert: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

Assignees

@haircommander haircommander

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @haircommander @rphillips