[fcos] templates/common/_base/units: disable docker #1898
Conversation
openshift-ci-robot
added
the
approved
|
/retest |
|
I’m all for disabling docker, but this looks like a real hacky way of doing it, so I think this should be noted in the commit message. (Properly disabling services is blocked by an ignition/systemd issue: coreos/fedora-coreos-tracker#392 |
vrutkovs
force-pushed
the
fcos-disable-docker
branch
from
9013d00 to
42ca54e
Compare
|
OVN failed to rollout on one node /test e2e-aws |
|
Let's put this on |
|
(Also FWIW I don't see any harm to having this on the master branch too, but we can deal with that when we get to merging the |
This adds a condition to docker.socket which it can't fullfil, so that OKD nodes would not run unused docker service.
vrutkovs
force-pushed
the
fcos-disable-docker
branch
from
42ca54e to
20481c7
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws unrelated test failures |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick master |
|
@vrutkovs: new pull request created: #1907 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dockerservice is not used and takes ~150MB of RAM on all nodesFixes okd-project/okd#243