Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fcos] GCP: add a script and a service which ensure GCP routes are set correctly #3067

Merged
merged 1 commit into from
Feb 6, 2020
Merged

[fcos] GCP: add a script and a service which ensure GCP routes are set correctly #3067

merged 1 commit into from
Feb 6, 2020

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Feb 5, 2020 •
edited
Loading

This would ensure bootstrap node reports as healthy to GCP LBs

xref okd-project/okd#38

@vrutkovs
GCP: add a script and a service which ensure GCP routes are set corre…
007b012 
…ctly

This would ensure bootstrap node reports as healthy to GCP LBs
@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 5, 2020

/cc @LorbusChris

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2020
@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 6, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 007b012 link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 6, 2020

/override ci/prow/e2e-vsphere

known test failures

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere

In response to this:

/override ci/prow/e2e-vsphere

known test failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Member

/lgtm
/approve
/cherry-pick master

@openshift-cherrypick-robot
Copy link

@LorbusChris: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@LorbusChris
Copy link
Member

/label bugzilla/valid-bug

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The label(s) /label bugzilla/valid-bug cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

/label bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton smarterclayton added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 37ced85 into openshift:fcos Feb 6, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 6, 2020
Closed
@openshift-cherrypick-robot
Copy link

@LorbusChris: new pull request created: #3071

In response to this:

/lgtm
/approve
/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@LorbusChris LorbusChris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrutkovs @openshift-ci-robot @LorbusChris @openshift-cherrypick-robot @smarterclayton @openshift-merge-robot