Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPNET-629: Add second HAProxy healthcheck port #1728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cybertron
Copy link
Member

In order to improve the robustness of the on-prem HAProxy instance, we have added a second healthcheck port in
openshift/machine-config-operator#4767 This corresponds to the existing 9444 port, but because the surrounding ports were already in use I moved it an even 10 away.

In order to improve the robustness of the on-prem HAProxy instance,
we have added a second healthcheck port in
openshift/machine-config-operator#4767
This corresponds to the existing 9444 port, but because the
surrounding ports were already in use I moved it an even 10 away.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2024

@cybertron: This pull request references OPNET-629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

In order to improve the robustness of the on-prem HAProxy instance, we have added a second healthcheck port in
openshift/machine-config-operator#4767 This corresponds to the existing 9444 port, but because the surrounding ports were already in use I moved it an even 10 away.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2024
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cybertron. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cybertron
Copy link
Member Author

/hold

I wanted to get this proposed, but before we merge it I want to get reviews on the dependent patch to ensure we actually implement this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@cybertron: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants